Refactor VideoDenoiser to work with I420Buffer, not VideoFrame.

webrtc/modules/video_processing/video_denoiser.h

 /*
  *  Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
 #ifndef WEBRTC_MODULES_VIDEO_PROCESSING_VIDEO_DENOISER_H_
 #define WEBRTC_MODULES_VIDEO_PROCESSING_VIDEO_DENOISER_H_
 
 #include <memory>
 
 #include "webrtc/modules/video_processing/util/denoiser_filter.h"
 #include "webrtc/modules/video_processing/util/noise_estimation.h"
 #include "webrtc/modules/video_processing/util/skin_detection.h"
 
 namespace webrtc {
 
 class VideoDenoiser {
  public:
   explicit VideoDenoiser(bool runtime_cpu_detection);
 
-  void DenoiseFrame(const VideoFrame& frame,
-                    VideoFrame* denoised_frame,
-                    VideoFrame* denoised_frame_prev,
+  // TODO(nisse): Let the denoised_frame and denoised_frame_prev be
+  // member variables referencing two I420Buffer, and return a refptr
+  // to the current one. When we also move the double-buffering logic
+  // from the caller.

[nisse-webrtc, 2016/06/17 07:34:47]

BTW, what do you think about this idea? It would simplify things for the caller
quite a lot.

[jackychen, 2016/06/17 23:56:50]

SG for me. You can surely make this change.

+  void DenoiseFrame(const rtc::scoped_refptr<VideoFrameBuffer>& frame,
+                    // Buffers are allocated/replaced when dimensions
+                    // change.
+                    rtc::scoped_refptr<I420Buffer>* denoised_frame,
+                    rtc::scoped_refptr<I420Buffer>* denoised_frame_prev,
                     bool noise_estimation_enabled);
 
  private:
-  void DenoiserReset(const VideoFrame& frame,
-                     VideoFrame* denoised_frame,
-                     VideoFrame* denoised_frame_prev);
+  void DenoiserReset(const rtc::scoped_refptr<VideoFrameBuffer>& frame,
+                     rtc::scoped_refptr<I420Buffer>* denoised_frame,
+                     rtc::scoped_refptr<I420Buffer>* denoised_frame_prev);
 
   // Check the mb position, return 1: close to the frame center (between 1/8
   // and 7/8 of width/height), 3: close to the border (out of 1/16 and 15/16
   // of width/height), 2: in between.
   int PositionCheck(int mb_row, int mb_col, int noise_level);
 
   // To reduce false detection in moving object detection (MOD).
   void ReduceFalseDetection(const std::unique_ptr<uint8_t[]>& d_status,
                             std::unique_ptr<uint8_t[]>* d_status_red,
                             int noise_level);
@@ skipping 27 matching lines @@
   // x_density_ and y_density_ are used in MOD process.
   std::unique_ptr<uint8_t[]> x_density_;
   std::unique_ptr<uint8_t[]> y_density_;
   // Save the return values by MbDenoise for each block.
   std::unique_ptr<DenoiserDecision[]> mb_filter_decision_;
 };
 
 }  // namespace webrtc
 
 #endif  // WEBRTC_MODULES_VIDEO_PROCESSING_VIDEO_DENOISER_H_