webrtc/modules/remote_bitrate_estimator/test/estimators/send_side.cc - Issue 2005313003: Propagate probing cluster id to SendTimeHistory.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/remote_bitrate_estimator/test/estimators/send_side.cc

Issue 2005313003: Propagate probing cluster id to SendTimeHistory. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Test probe_cluster_id in PacketRouterTest. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/remote_bitrate_estimator/send_time_history_unittest.cc ('k') | webrtc/modules/remote_bitrate_estimator/test/packet_sender.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/remote_bitrate_estimator/test/estimators/send_side.cc

diff --git a/webrtc/modules/remote_bitrate_estimator/test/estimators/send_side.cc b/webrtc/modules/remote_bitrate_estimator/test/estimators/send_side.cc

index 3cf7c752a07e911bd680a3c48e0addaf57518ecb..111521ea2e877ed107324194bbdb0791aba59ca1 100644

--- a/webrtc/modules/remote_bitrate_estimator/test/estimators/send_side.cc

+++ b/webrtc/modules/remote_bitrate_estimator/test/estimators/send_side.cc

@@ -92,9 +92,11 @@ void FullBweSender::OnPacketsSent(const Packets& packets) {

for (Packet* packet : packets) {

if (packet->GetPacketType() == Packet::kMedia) {

MediaPacket* media_packet = static_cast<MediaPacket*>(packet);

- send_time_history_.AddAndRemoveOld(media_packet->header().sequenceNumber,

- media_packet->payload_size(),

- packet->paced());

+ // TODO(philipel): Add probe_cluster_id to Packet class in order

+ // to create tests for probing using cluster ids.

+ send_time_history_.AddAndRemoveOld(

+ media_packet->header().sequenceNumber, media_packet->payload_size(),

+ packet->paced(), PacketInfo::kNotAProbe);

send_time_history_.OnSentPacket(media_packet->header().sequenceNumber,

media_packet->sender_timestamp_ms());

}