Propagate probing cluster id to SendTimeHistory.

webrtc/modules/rtp_rtcp/include/rtp_rtcp_defines.h

Index: webrtc/modules/rtp_rtcp/include/rtp_rtcp_defines.h
diff --git a/webrtc/modules/rtp_rtcp/include/rtp_rtcp_defines.h b/webrtc/modules/rtp_rtcp/include/rtp_rtcp_defines.h
index 282483b0953fda31fd14b9877924dcf75fc78e95..cf4d6c900277b5a353d479d62938af5671aa6ab1 100644
--- a/webrtc/modules/rtp_rtcp/include/rtp_rtcp_defines.h
+++ b/webrtc/modules/rtp_rtcp/include/rtp_rtcp_defines.h
@@ -251,26 +251,26 @@ struct PacketInfo {
              int64_t send_time_ms,
              uint16_t sequence_number,
              size_t payload_size,
-             bool was_paced)
+             int probe_cluster_id)
       : PacketInfo(-1,
                    arrival_time_ms,
                    send_time_ms,
                    sequence_number,
                    payload_size,
-                   was_paced) {}
+                   probe_cluster_id) {}
 
   PacketInfo(int64_t creation_time_ms,
              int64_t arrival_time_ms,
              int64_t send_time_ms,
              uint16_t sequence_number,
              size_t payload_size,
-             bool was_paced)
+             int probe_cluster_id)
       : creation_time_ms(creation_time_ms),
         arrival_time_ms(arrival_time_ms),
         send_time_ms(send_time_ms),
         sequence_number(sequence_number),
         payload_size(payload_size),
-        was_paced(was_paced) {}
+        probe_cluster_id(probe_cluster_id) {}
 
   // Time corresponding to when this object was created.
   int64_t creation_time_ms;
@@ -285,8 +285,8 @@ struct PacketInfo {
   uint16_t sequence_number;
   // Size of the packet excluding RTP headers.
   size_t payload_size;
-  // True if the packet was paced out by the pacer.
-  bool was_paced;
+  // Which probing cluster this packet belongs to, -1 means no cluster.

[danilchap, 2016/05/25 13:00:54]

may be something like '-1 means packet is not used for probing'
and/or add a constant like 'constexpr int kNotAProbe = -1;' and use that one
instead of mystical value -1. (this struct looks like a good place to hold this
constant)

[philipel, 2016/05/26 09:59:12]

Defined kNotAProbe in this class.

+  int probe_cluster_id;
 };
 
 class TransportFeedbackObserver {
@@ -298,7 +298,7 @@ class TransportFeedbackObserver {
   // must be set to 0.
   virtual void AddPacket(uint16_t sequence_number,
                          size_t length,
-                         bool was_paced) = 0;
+                         int probe_cluster_id) = 0;
 
   virtual void OnTransportFeedback(const rtcp::TransportFeedback& feedback) = 0;
 };