Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Side by Side Diff: webrtc/modules/rtp_rtcp/include/rtp_rtcp_defines.h

Issue 2005313003: Propagate probing cluster id to SendTimeHistory. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Feedback fixes. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 226 matching lines...) Expand 10 before | Expand all | Expand 10 after
237 237
238 virtual void OnReceivedRtcpReceiverReport( 238 virtual void OnReceivedRtcpReceiverReport(
239 const ReportBlockList& report_blocks, 239 const ReportBlockList& report_blocks,
240 int64_t rtt, 240 int64_t rtt,
241 int64_t now_ms) = 0; 241 int64_t now_ms) = 0;
242 242
243 virtual ~RtcpBandwidthObserver() {} 243 virtual ~RtcpBandwidthObserver() {}
244 }; 244 };
245 245
246 struct PacketInfo { 246 struct PacketInfo {
247 static constexpr int kNotAProbe = -1;
248
247 PacketInfo(int64_t arrival_time_ms, uint16_t sequence_number) 249 PacketInfo(int64_t arrival_time_ms, uint16_t sequence_number)
248 : PacketInfo(-1, arrival_time_ms, -1, sequence_number, 0, false) {} 250 : PacketInfo(-1, arrival_time_ms, -1, sequence_number, 0, kNotAProbe) {}
249 251
250 PacketInfo(int64_t arrival_time_ms, 252 PacketInfo(int64_t arrival_time_ms,
251 int64_t send_time_ms, 253 int64_t send_time_ms,
252 uint16_t sequence_number, 254 uint16_t sequence_number,
253 size_t payload_size, 255 size_t payload_size,
254 bool was_paced) 256 int probe_cluster_id)
255 : PacketInfo(-1, 257 : PacketInfo(-1,
256 arrival_time_ms, 258 arrival_time_ms,
257 send_time_ms, 259 send_time_ms,
258 sequence_number, 260 sequence_number,
259 payload_size, 261 payload_size,
260 was_paced) {} 262 probe_cluster_id) {}
261 263
262 PacketInfo(int64_t creation_time_ms, 264 PacketInfo(int64_t creation_time_ms,
263 int64_t arrival_time_ms, 265 int64_t arrival_time_ms,
264 int64_t send_time_ms, 266 int64_t send_time_ms,
265 uint16_t sequence_number, 267 uint16_t sequence_number,
266 size_t payload_size, 268 size_t payload_size,
267 bool was_paced) 269 int probe_cluster_id)
268 : creation_time_ms(creation_time_ms), 270 : creation_time_ms(creation_time_ms),
269 arrival_time_ms(arrival_time_ms), 271 arrival_time_ms(arrival_time_ms),
270 send_time_ms(send_time_ms), 272 send_time_ms(send_time_ms),
271 sequence_number(sequence_number), 273 sequence_number(sequence_number),
272 payload_size(payload_size), 274 payload_size(payload_size),
273 was_paced(was_paced) {} 275 probe_cluster_id(probe_cluster_id) {}
274 276
275 // Time corresponding to when this object was created. 277 // Time corresponding to when this object was created.
276 int64_t creation_time_ms; 278 int64_t creation_time_ms;
277 // Time corresponding to when the packet was received. Timestamped with the 279 // Time corresponding to when the packet was received. Timestamped with the
278 // receiver's clock. 280 // receiver's clock.
279 int64_t arrival_time_ms; 281 int64_t arrival_time_ms;
280 // Time corresponding to when the packet was sent, timestamped with the 282 // Time corresponding to when the packet was sent, timestamped with the
281 // sender's clock. 283 // sender's clock.
282 int64_t send_time_ms; 284 int64_t send_time_ms;
283 // Packet identifier, incremented with 1 for every packet generated by the 285 // Packet identifier, incremented with 1 for every packet generated by the
284 // sender. 286 // sender.
285 uint16_t sequence_number; 287 uint16_t sequence_number;
286 // Size of the packet excluding RTP headers. 288 // Size of the packet excluding RTP headers.
287 size_t payload_size; 289 size_t payload_size;
288 // True if the packet was paced out by the pacer. 290 // Which probing cluster this packet belongs to, kNotAProbe means no cluster.
289 bool was_paced; 291 int probe_cluster_id;
290 }; 292 };
291 293
292 class TransportFeedbackObserver { 294 class TransportFeedbackObserver {
293 public: 295 public:
294 TransportFeedbackObserver() {} 296 TransportFeedbackObserver() {}
295 virtual ~TransportFeedbackObserver() {} 297 virtual ~TransportFeedbackObserver() {}
296 298
297 // Note: Transport-wide sequence number as sequence number. Arrival time 299 // Note: Transport-wide sequence number as sequence number. Arrival time
298 // must be set to 0. 300 // must be set to 0.
299 virtual void AddPacket(uint16_t sequence_number, 301 virtual void AddPacket(uint16_t sequence_number,
300 size_t length, 302 size_t length,
301 bool was_paced) = 0; 303 int probe_cluster_id) = 0;
304
305 virtual void AddPacket(uint16_t sequence_number, size_t length, bool wut)
306 __attribute__((deprecated("Old Version!"))) {}
stefan-webrtc 2016/05/26 16:29:50 Use RTC_DEPRECATED.
302 307
303 virtual void OnTransportFeedback(const rtcp::TransportFeedback& feedback) = 0; 308 virtual void OnTransportFeedback(const rtcp::TransportFeedback& feedback) = 0;
304 }; 309 };
305 310
306 class RtcpRttStats { 311 class RtcpRttStats {
307 public: 312 public:
308 virtual void OnRttUpdate(int64_t rtt) = 0; 313 virtual void OnRttUpdate(int64_t rtt) = 0;
309 314
310 virtual int64_t LastProcessedRtt() const = 0; 315 virtual int64_t LastProcessedRtt() const = 0;
311 316
(...skipping 72 matching lines...) Expand 10 before | Expand all | Expand 10 after
384 class TransportSequenceNumberAllocator { 389 class TransportSequenceNumberAllocator {
385 public: 390 public:
386 TransportSequenceNumberAllocator() {} 391 TransportSequenceNumberAllocator() {}
387 virtual ~TransportSequenceNumberAllocator() {} 392 virtual ~TransportSequenceNumberAllocator() {}
388 393
389 virtual uint16_t AllocateSequenceNumber() = 0; 394 virtual uint16_t AllocateSequenceNumber() = 0;
390 }; 395 };
391 396
392 } // namespace webrtc 397 } // namespace webrtc
393 #endif // WEBRTC_MODULES_RTP_RTCP_INCLUDE_RTP_RTCP_DEFINES_H_ 398 #endif // WEBRTC_MODULES_RTP_RTCP_INCLUDE_RTP_RTCP_DEFINES_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698