Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Side by Side Diff: webrtc/modules/pacing/paced_sender.h

Issue 2005313003: Propagate probing cluster id to SendTimeHistory. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Feedback fixes. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 26 matching lines...) Expand all
37 public: 37 public:
38 // Note: packets sent as a result of a callback should not pass by this 38 // Note: packets sent as a result of a callback should not pass by this
39 // module again. 39 // module again.
40 // Called when it's time to send a queued packet. 40 // Called when it's time to send a queued packet.
41 // Returns false if packet cannot be sent. 41 // Returns false if packet cannot be sent.
42 virtual bool TimeToSendPacket(uint32_t ssrc, 42 virtual bool TimeToSendPacket(uint32_t ssrc,
43 uint16_t sequence_number, 43 uint16_t sequence_number,
44 int64_t capture_time_ms, 44 int64_t capture_time_ms,
45 bool retransmission, 45 bool retransmission,
46 int probe_cluster_id) = 0; 46 int probe_cluster_id) = 0;
47
47 // Called when it's a good time to send a padding data. 48 // Called when it's a good time to send a padding data.
48 // Returns the number of bytes sent. 49 // Returns the number of bytes sent.
49 virtual size_t TimeToSendPadding(size_t bytes) = 0; 50 virtual size_t TimeToSendPadding(size_t bytes, int probe_cluster_id) = 0;
50 51
51 protected: 52 protected:
52 virtual ~PacketSender() {} 53 virtual ~PacketSender() {}
53 }; 54 };
54 55
55 // Expected max pacer delay in ms. If ExpectedQueueTimeMs() is higher than 56 // Expected max pacer delay in ms. If ExpectedQueueTimeMs() is higher than
56 // this value, the packet producers should wait (eg drop frames rather than 57 // this value, the packet producers should wait (eg drop frames rather than
57 // encoding them). Bitrate sent may temporarily exceed target set by 58 // encoding them). Bitrate sent may temporarily exceed target set by
58 // UpdateBitrate() so that this limit will be upheld. 59 // UpdateBitrate() so that this limit will be upheld.
59 static const int64_t kMaxQueueLengthMs; 60 static const int64_t kMaxQueueLengthMs;
(...skipping 66 matching lines...) Expand 10 before | Expand all | Expand 10 after
126 // Process any pending packets in the queue(s). 127 // Process any pending packets in the queue(s).
127 void Process() override; 128 void Process() override;
128 129
129 private: 130 private:
130 // Updates the number of bytes that can be sent for the next time interval. 131 // Updates the number of bytes that can be sent for the next time interval.
131 void UpdateBytesPerInterval(int64_t delta_time_in_ms) 132 void UpdateBytesPerInterval(int64_t delta_time_in_ms)
132 EXCLUSIVE_LOCKS_REQUIRED(critsect_); 133 EXCLUSIVE_LOCKS_REQUIRED(critsect_);
133 134
134 bool SendPacket(const paced_sender::Packet& packet, int probe_cluster_id) 135 bool SendPacket(const paced_sender::Packet& packet, int probe_cluster_id)
135 EXCLUSIVE_LOCKS_REQUIRED(critsect_); 136 EXCLUSIVE_LOCKS_REQUIRED(critsect_);
136 void SendPadding(size_t padding_needed) EXCLUSIVE_LOCKS_REQUIRED(critsect_); 137 void SendPadding(size_t padding_needed, int probe_cluster_id)
138 EXCLUSIVE_LOCKS_REQUIRED(critsect_);
137 139
138 Clock* const clock_; 140 Clock* const clock_;
139 PacketSender* const packet_sender_; 141 PacketSender* const packet_sender_;
140 142
141 std::unique_ptr<CriticalSectionWrapper> critsect_; 143 std::unique_ptr<CriticalSectionWrapper> critsect_;
142 bool paused_ GUARDED_BY(critsect_); 144 bool paused_ GUARDED_BY(critsect_);
143 bool probing_enabled_; 145 bool probing_enabled_;
144 // This is the media budget, keeping track of how many bits of media 146 // This is the media budget, keeping track of how many bits of media
145 // we can pace out during the current interval. 147 // we can pace out during the current interval.
146 std::unique_ptr<paced_sender::IntervalBudget> media_budget_ 148 std::unique_ptr<paced_sender::IntervalBudget> media_budget_
(...skipping 11 matching lines...) Expand all
158 uint32_t min_send_bitrate_kbps_ GUARDED_BY(critsect_); 160 uint32_t min_send_bitrate_kbps_ GUARDED_BY(critsect_);
159 uint32_t pacing_bitrate_kbps_ GUARDED_BY(critsect_); 161 uint32_t pacing_bitrate_kbps_ GUARDED_BY(critsect_);
160 162
161 int64_t time_last_update_us_ GUARDED_BY(critsect_); 163 int64_t time_last_update_us_ GUARDED_BY(critsect_);
162 164
163 std::unique_ptr<paced_sender::PacketQueue> packets_ GUARDED_BY(critsect_); 165 std::unique_ptr<paced_sender::PacketQueue> packets_ GUARDED_BY(critsect_);
164 uint64_t packet_counter_; 166 uint64_t packet_counter_;
165 }; 167 };
166 } // namespace webrtc 168 } // namespace webrtc
167 #endif // WEBRTC_MODULES_PACING_PACED_SENDER_H_ 169 #endif // WEBRTC_MODULES_PACING_PACED_SENDER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698