Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Issue 2004463003: Handle any number of role conflicts; not just the first. (Closed)

Created:
4 years, 7 months ago by Taylor Brandstetter
Modified:
4 years, 6 months ago
Reviewers:
pthatcher1, honghaiz3
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Handle any number of role conflicts; not just the first. I think the code that only allowed one role conflict was a workaround for our old implementation (TransportChannelProxy, etc.). Not necessary now, with TransportController. BUG=webrtc:5470 Committed: https://crrev.com/1c20610ede85f52d10e68e7907737994e64de2cb Cr-Commit-Position: refs/heads/master@{#12949}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -13 lines) Patch
M webrtc/p2p/base/transportcontroller.h View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/p2p/base/transportcontroller.cc View 1 chunk +8 lines, -11 lines 0 comments Download
M webrtc/p2p/base/transportcontroller_unittest.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Taylor Brandstetter
4 years, 7 months ago (2016-05-20 22:01:09 UTC) #2
pthatcher1
lgtm
4 years, 6 months ago (2016-05-27 17:23:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2004463003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2004463003/1
4 years, 6 months ago (2016-05-27 19:33:46 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-05-27 20:34:43 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-05-27 20:34:53 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1c20610ede85f52d10e68e7907737994e64de2cb
Cr-Commit-Position: refs/heads/master@{#12949}

Powered by Google App Engine
This is Rietveld 408576698