Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 2003983002: UI for AppRTC Android demo that doesn't require Design Support Library (Closed)

Created:
4 years, 7 months ago by sakal
Modified:
4 years, 7 months ago
Reviewers:
magjed_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc, AlexG
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

UI for AppRTC Android demo that doesn't require Design Support Library For simplicity, this CL removes the need for Design Support Library. UI is slightly changed for this to be possible. Floating Action Button for adding favorite is removed and instead there's a button next to the TextView. Committed: https://crrev.com/05cdb85012a5a4bf369b7f65459cafb1efc8e604 Cr-Commit-Position: refs/heads/master@{#12861}

Patch Set 1 #

Messages

Total messages: 18 (9 generated)
sakal
Magnus, can you take a look please.
4 years, 7 months ago (2016-05-23 11:02:19 UTC) #3
magjed_webrtc
lgtm
4 years, 7 months ago (2016-05-23 12:17:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2003983002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2003983002/1
4 years, 7 months ago (2016-05-23 12:18:47 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_dbg on ...
4 years, 7 months ago (2016-05-23 14:19:26 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2003983002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2003983002/1
4 years, 7 months ago (2016-05-23 14:28:25 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_dbg on ...
4 years, 7 months ago (2016-05-23 16:28:56 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2003983002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2003983002/1
4 years, 7 months ago (2016-05-24 07:15:34 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-24 07:18:14 UTC) #16
commit-bot: I haz the power
4 years, 7 months ago (2016-05-24 07:18:24 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/05cdb85012a5a4bf369b7f65459cafb1efc8e604
Cr-Commit-Position: refs/heads/master@{#12861}

Powered by Google App Engine
This is Rietveld 408576698