webrtc/modules/audio_processing/agc/legacy/analog_agc.c - Issue 2003623003: Re-enable UBsan on AGC.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_processing/agc/legacy/analog_agc.c

Issue 2003623003: Re-enable UBsan on AGC. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: addressing another place Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/modules/audio_processing/agc/legacy/analog_agc.c

diff --git a/webrtc/modules/audio_processing/agc/legacy/analog_agc.c b/webrtc/modules/audio_processing/agc/legacy/analog_agc.c

index 36c67c282a02a1b9096f01aa8bda572624f8b67b..57bc5fe189381441fe519e92a4fc31b692d275e8 100644

--- a/webrtc/modules/audio_processing/agc/legacy/analog_agc.c

+++ b/webrtc/modules/audio_processing/agc/legacy/analog_agc.c

@@ -474,7 +474,7 @@ void WebRtcAgc_SaturationCtrl(LegacyAgc* stt,

void WebRtcAgc_ZeroCtrl(LegacyAgc* stt, int32_t* inMicLevel, int32_t* env) {

int16_t i;

- int32_t tmp32 = 0;

+ int64_t tmp32 = 0;

peah-webrtc 2016/06/03 08:34:46 I think the variable name should be changed as wel

int32_t midVal;

/* Is the input signal zero? */

« no previous file with comments | « tools/ubsan/blacklist.txt ('k') | webrtc/modules/audio_processing/agc/legacy/digital_agc.c » ('j') | no next file with comments »