Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 2003203004: NetEq: Fix stats counting in muted mode (Closed)

Created:
4 years, 7 months ago by hlundin-webrtc
Modified:
4 years, 6 months ago
Reviewers:
tlegrand-webrtc
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

NetEq: Fix stats counting in muted mode The NetEqNetworkStatistics::expand_rate was not incremented during muted state, which caused under-reporting of that metric. This change fixes that. BUG=chromium:613321, webrtc:5608 Committed: https://crrev.com/612c25e7afad62675510cf3269701b28dc053605 Cr-Commit-Position: refs/heads/master@{#12894}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M webrtc/modules/audio_coding/neteq/neteq_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/neteq_unittest.cc View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
hlundin-webrtc
Tina, Please, take a look. Thanks!
4 years, 7 months ago (2016-05-24 13:43:05 UTC) #2
tlegrand-webrtc
lgtm
4 years, 6 months ago (2016-05-25 14:18:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2003203004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2003203004/1
4 years, 6 months ago (2016-05-25 14:23:43 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-05-25 15:21:09 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-05-25 15:21:15 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/612c25e7afad62675510cf3269701b28dc053605
Cr-Commit-Position: refs/heads/master@{#12894}

Powered by Google App Engine
This is Rietveld 408576698