Android: Drop old frame in SurfaceTextureHelper.startListening()

Android: Drop old frame in SurfaceTextureHelper.startListening()

Drop any pending texture frame when SurfaceTextureHelper.startListening()
is called because the frame might be from the previous
startListening()/stopListening() capture session. This typically happens
when switching between the front/back camera, and an old frame will get
incorrect rotation and mirroring because of the front/back camera
mismatch.

Dropping the frame in SurfaceTextureHelper also removes the need for
the |dropNextFrame| logic in VideoCapturerAndroid.

R=perkj@webrtc.org

Committed: https://chromium.googlesource.com/external/webrtc/+/181310fb6fe2aff416b112b7e9945d651566fab0

[magjed_webrtc, 2016-05-23 11:50:17]

Description was changed from

==========
Android: Drop old frame in SurfaceTextureHelper.startListening()

Drop any pending texture frame when SurfaceTextureHelper.startListening()
is called because the frame might be from the previous
startListening()/stopListening() capture session. This typically happens
when switching between the front/back camera, and an old frame will get
incorrect rotation and mirroring because of the front/back camera
mismatch.

Dropping the frame in the SurfaceTextureHelper also removes the need for
the |dropNextFrame| logic in VideoCapturerAndroid.
==========

to

==========
Android: Drop old frame in SurfaceTextureHelper.startListening()

Drop any pending texture frame when SurfaceTextureHelper.startListening()
is called because the frame might be from the previous
startListening()/stopListening() capture session. This typically happens
when switching between the front/back camera, and an old frame will get
incorrect rotation and mirroring because of the front/back camera
mismatch.

Dropping the frame in SurfaceTextureHelper also removes the need for
the |dropNextFrame| logic in VideoCapturerAndroid.
==========

[magjed_webrtc, 2016-05-23 11:56:16]

magjed@webrtc.org changed reviewers:
+ perkj@webrtc.org

[magjed_webrtc, 2016-05-23 12:00:55]

perkj - Please take a look. I noticed this while working on a Camera2
implementation that has the same problem with the first frame after switchCamera
as the Camera1 implementation. Dropping the frame in
SurfaceTextureHelper.startListening() solved the problem for camera2. I was
curious, so I tried this fix for Camera1 as well, and it solves the problem
there as well. I have tested with Nexus6 and Android One.

[perkj_webrtc, 2016-05-23 12:32:28]

Nice catch.

lgtm

[magjed_webrtc, 2016-05-23 12:36:08]

The CQ bit was checked by magjed@webrtc.org

[commit-bot: I haz the power, 2016-05-23 12:36:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2002963002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2002963002/1

[commit-bot: I haz the power, 2016-05-23 13:14:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-23 13:14:37]

Try jobs failed on following builders:
  android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  android_dbg on tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[commit-bot: I haz the power, 2016-05-23 14:27:04]

Description was changed from

==========
Android: Drop old frame in SurfaceTextureHelper.startListening()

Drop any pending texture frame when SurfaceTextureHelper.startListening()
is called because the frame might be from the previous
startListening()/stopListening() capture session. This typically happens
when switching between the front/back camera, and an old frame will get
incorrect rotation and mirroring because of the front/back camera
mismatch.

Dropping the frame in SurfaceTextureHelper also removes the need for
the |dropNextFrame| logic in VideoCapturerAndroid.
==========

to

==========
Android: Drop old frame in SurfaceTextureHelper.startListening()

Drop any pending texture frame when SurfaceTextureHelper.startListening()
is called because the frame might be from the previous
startListening()/stopListening() capture session. This typically happens
when switching between the front/back camera, and an old frame will get
incorrect rotation and mirroring because of the front/back camera
mismatch.

Dropping the frame in SurfaceTextureHelper also removes the need for
the |dropNextFrame| logic in VideoCapturerAndroid.

R=perkj@webrtc.org

Committed: https://crrev.com/181310fb6fe2aff416b112b7e9945d651566fab0
Cr-Commit-Position: refs/heads/master@{#12849}
==========

[magjed_webrtc, 2016-05-23 14:27:04]

Description was changed from

==========
Android: Drop old frame in SurfaceTextureHelper.startListening()

Drop any pending texture frame when SurfaceTextureHelper.startListening()
is called because the frame might be from the previous
startListening()/stopListening() capture session. This typically happens
when switching between the front/back camera, and an old frame will get
incorrect rotation and mirroring because of the front/back camera
mismatch.

Dropping the frame in SurfaceTextureHelper also removes the need for
the |dropNextFrame| logic in VideoCapturerAndroid.

R=perkj@webrtc.org

Committed: https://crrev.com/181310fb6fe2aff416b112b7e9945d651566fab0
Cr-Commit-Position: refs/heads/master@{#12849}
==========

to

==========
Android: Drop old frame in SurfaceTextureHelper.startListening()

Drop any pending texture frame when SurfaceTextureHelper.startListening()
is called because the frame might be from the previous
startListening()/stopListening() capture session. This typically happens
when switching between the front/back camera, and an old frame will get
incorrect rotation and mirroring because of the front/back camera
mismatch.

Dropping the frame in SurfaceTextureHelper also removes the need for
the |dropNextFrame| logic in VideoCapturerAndroid.

R=perkj@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/181310fb6fe2aff416b112b7e...
==========

[commit-bot: I haz the power, 2016-05-23 14:27:05]

Patchset 1 (id:??) landed as
https://crrev.com/181310fb6fe2aff416b112b7e9945d651566fab0
Cr-Commit-Position: refs/heads/master@{#12849}

[magjed_webrtc, 2016-05-23 14:27:06]

Committed patchset #1 (id:1) manually as
181310fb6fe2aff416b112b7e9945d651566fab0 (presubmit successful).