Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 2002403002: Revert of Change initial DTLS retransmission timer from 1 second to 50ms. (Closed)

Created:
4 years, 7 months ago by philipel
Modified:
4 years, 7 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Change initial DTLS retransmission timer from 1 second to 50ms. (patchset #2 id:20001 of https://codereview.webrtc.org/1981463002/ ) Reason for revert: Seems like this CL cause DtlsTransportChannelTest.TestReceiveClientHelloBeforeRemoteFingerprint DtlsTransportChannelTest.TestReceiveClientHelloBeforeWritable to consistently fail on Win DrMemory Full and for DtlsTransportChannelTest.TestReceiveClientHelloBeforeRemoteFingerprint DtlsTransportChannelTest.TestReceiveClientHelloBeforeWritable to consistently fail on Linux Memcheck Original issue's description: > Change initial DTLS retransmission timer from 1 second to 50ms. > > This will help ensure a timely DTLS handshake when there's packet > loss. It will likely result in spurious retransmissions (since the > RTT is usually > 50ms), but since exponential backoff is still used, > there will at most be ~4 extra retransmissions. For a time-sensitive > application like WebRTC this seems like a reasonable tradeoff. > > R=juberti@chromium.org, juberti@webrtc.org, pthatcher@webrtc.org > > Committed: https://crrev.com/1e435628366fb9fed71632369f05928ed857d8ef > Cr-Commit-Position: refs/heads/master@{#12853} TBR=pthatcher@webrtc.org,juberti@webrtc.org,juberti@chromium.org,deadbeef@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/49c0869825c4c6165d64afc1002d40ecb68240e5 Cr-Commit-Position: refs/heads/master@{#12864}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -9 lines) Patch
M webrtc/base/opensslstreamadapter.cc View 1 chunk +3 lines, -9 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
philipel
Created Revert of Change initial DTLS retransmission timer from 1 second to 50ms.
4 years, 7 months ago (2016-05-24 08:49:30 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2002403002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2002403002/1
4 years, 7 months ago (2016-05-24 08:49:34 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-24 08:49:46 UTC) #4
commit-bot: I haz the power
4 years, 7 months ago (2016-05-24 08:49:55 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/49c0869825c4c6165d64afc1002d40ecb68240e5
Cr-Commit-Position: refs/heads/master@{#12864}

Powered by Google App Engine
This is Rietveld 408576698