Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Unified Diff: webrtc/examples/androidapp/src/org/appspot/apprtc/ConnectActivity.java

Issue 2002093002: Add an option to disable built-in AEC to AppRTC Android Demo (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Export AEC not available string to strings.xml Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/examples/androidapp/src/org/appspot/apprtc/ConnectActivity.java
diff --git a/webrtc/examples/androidapp/src/org/appspot/apprtc/ConnectActivity.java b/webrtc/examples/androidapp/src/org/appspot/apprtc/ConnectActivity.java
index 557c3e8c73e3836b0b21c86ff395fa7d6aef8e4f..ad4c756d26c7791a65c0bc68dbe8282838347f51 100644
--- a/webrtc/examples/androidapp/src/org/appspot/apprtc/ConnectActivity.java
+++ b/webrtc/examples/androidapp/src/org/appspot/apprtc/ConnectActivity.java
@@ -71,6 +71,7 @@ public class ConnectActivity extends AppCompatActivity {
private String keyprefNoAudioProcessingPipeline;
private String keyprefAecDump;
private String keyprefOpenSLES;
+ private String keyprefDisableBuiltInAec;
private String keyprefDisplayHud;
private String keyprefTracing;
private String keyprefRoomServerUrl;
@@ -101,6 +102,7 @@ public class ConnectActivity extends AppCompatActivity {
keyprefNoAudioProcessingPipeline = getString(R.string.pref_noaudioprocessing_key);
keyprefAecDump = getString(R.string.pref_aecdump_key);
keyprefOpenSLES = getString(R.string.pref_opensles_key);
+ keyprefDisableBuiltInAec = getString(R.string.pref_disable_built_in_aec_key);
keyprefDisplayHud = getString(R.string.pref_displayhud_key);
keyprefTracing = getString(R.string.pref_tracing_key);
keyprefRoomServerUrl = getString(R.string.pref_room_server_url_key);
@@ -289,6 +291,12 @@ public class ConnectActivity extends AppCompatActivity {
keyprefOpenSLES,
Boolean.valueOf(getString(R.string.pref_opensles_default)));
+ // Check Disable built-in AEC flag.
+ boolean disableBuiltInAEC = sharedPref.getBoolean(
+ keyprefDisableBuiltInAec,
+ Boolean.valueOf(getString(R.string.pref_disable_built_in_aec_default)));
+
+
// Get video resolution from settings.
int videoWidth = 0;
int videoHeight = 0;
@@ -373,6 +381,7 @@ public class ConnectActivity extends AppCompatActivity {
noAudioProcessing);
intent.putExtra(CallActivity.EXTRA_AECDUMP_ENABLED, aecDump);
intent.putExtra(CallActivity.EXTRA_OPENSLES_ENABLED, useOpenSLES);
+ intent.putExtra(CallActivity.EXTRA_DISABLE_BUILT_IN_AEC, disableBuiltInAEC);
intent.putExtra(CallActivity.EXTRA_AUDIO_BITRATE, audioStartBitrate);
intent.putExtra(CallActivity.EXTRA_AUDIOCODEC, audioCodec);
intent.putExtra(CallActivity.EXTRA_DISPLAY_HUD, displayHud);

Powered by Google App Engine
This is Rietveld 408576698