Refactoring: Hide VideoCodec.codecSpecific as "private"

webrtc/common_types.cc

Index: webrtc/common_types.cc
diff --git a/webrtc/common_types.cc b/webrtc/common_types.cc
index 7b99f3c5a83859d17a6891b99c49dc4d218808ee..7e8d11a32c702ae1b3788bbdac6569b5b679b1b4 100644
--- a/webrtc/common_types.cc
+++ b/webrtc/common_types.cc
@@ -48,4 +48,23 @@ RTPHeader::RTPHeader()
   memset(&arrOfCSRCs, 0, sizeof(arrOfCSRCs));
 }
 
+VideoCodec::VideoCodec()
+    : codecType(kVideoCodecUnknown),
+      plName(""),

[hta-webrtc, 2016/05/20 12:11:31]

BTW, plName is a 16-character array. The Android compiler barfed on this
initialization, while the others accepted it - advice?

[tommi, 2016/05/21 11:17:08]

try plName(),

[hta-webrtc, 2016/05/23 13:30:16]

Done.

+      plType(0),
+      width(0),
+      height(0),
+      startBitrate(0),
+      maxBitrate(0),
+      minBitrate(0),
+      targetBitrate(0),
+      maxFramerate(0),
+      qpMax(0),
+      numberOfSimulcastStreams(0),
+      mode(kRealtimeVideo) {
+  memset(&simulcastStream, 0, sizeof(simulcastStream));

[tommi, 2016/05/20 11:34:55]

initialize these in the initializer list instead of using memset.  memset() can
have worse side effects if the type changes.  If you could also fix the memset()
above, then that would be good.

[hta-webrtc, 2016/05/20 12:11:31]

All of these are arrays. Is there a good way to initialize arrays with an
initializer?

(I'd like to make them all have constructors that zeroed them, but that's too
many changes for one little CL.)

[tommi, 2016/05/21 11:17:07]

Same here. Try:

simulcastStream(),
spatialLayers(),
codecSpecific(),

in the initializer list

[hta-webrtc, 2016/05/23 13:30:16]

Done.

+  memset(&spatialLayers, 0, sizeof(spatialLayers));
+  memset(&codecSpecific_, 0, sizeof(codecSpecific_));
+}
+
 }  // namespace webrtc