Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Unified Diff: webrtc/modules/video_coding/codecs/vp8/simulcast_unittest.h

Issue 2001533003: Refactoring: Hide VideoCodec.codecSpecific as "private" (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Rebased Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/video_coding/codecs/vp8/simulcast_unittest.h
diff --git a/webrtc/modules/video_coding/codecs/vp8/simulcast_unittest.h b/webrtc/modules/video_coding/codecs/vp8/simulcast_unittest.h
index e2d5bb87384fbbca678e00584162ebe2a7586dbd..56ad3a710d29528e30ec6d65636bf2062d2c5b36 100644
--- a/webrtc/modules/video_coding/codecs/vp8/simulcast_unittest.h
+++ b/webrtc/modules/video_coding/codecs/vp8/simulcast_unittest.h
@@ -153,7 +153,7 @@ class SkipEncodingUnusedStreamsTest {
VideoCodec* settings,
uint32_t target_bitrate) {
SpyingTemporalLayersFactory spy_factory;
- settings->codecSpecific.VP8.tl_factory = &spy_factory;
+ settings->VP8()->tl_factory = &spy_factory;
EXPECT_EQ(0, encoder->InitEncode(settings, 1, 1200));
encoder->SetRates(target_bitrate, 30);
@@ -288,13 +288,13 @@ class TestVp8Simulcast : public ::testing::Test {
ConfigureStream(kDefaultWidth, kDefaultHeight, kMaxBitrates[2],
kMinBitrates[2], kTargetBitrates[2],
&settings->simulcastStream[2], temporal_layer_profile[2]);
- settings->codecSpecific.VP8.resilience = kResilientStream;
- settings->codecSpecific.VP8.denoisingOn = true;
- settings->codecSpecific.VP8.errorConcealmentOn = false;
- settings->codecSpecific.VP8.automaticResizeOn = false;
- settings->codecSpecific.VP8.feedbackModeOn = false;
- settings->codecSpecific.VP8.frameDroppingOn = true;
- settings->codecSpecific.VP8.keyFrameInterval = 3000;
+ settings->VP8()->resilience = kResilientStream;
+ settings->VP8()->denoisingOn = true;
+ settings->VP8()->errorConcealmentOn = false;
+ settings->VP8()->automaticResizeOn = false;
+ settings->VP8()->feedbackModeOn = false;
+ settings->VP8()->frameDroppingOn = true;
+ settings->VP8()->keyFrameInterval = 3000;
}
static void ConfigureStream(int width,
@@ -563,7 +563,7 @@ class TestVp8Simulcast : public ::testing::Test {
void SwitchingToOneStream(int width, int height) {
// Disable all streams except the last and set the bitrate of the last to
// 100 kbps. This verifies the way GTP switches to screenshare mode.
- settings_.codecSpecific.VP8.numberOfTemporalLayers = 1;
+ settings_.VP8()->numberOfTemporalLayers = 1;
settings_.maxBitrate = 100;
settings_.startBitrate = 100;
settings_.width = width;

Powered by Google App Engine
This is Rietveld 408576698