webrtc/modules/video_coding/codecs/h264/h264_encoder_impl.cc - Issue 2001533003: Refactoring: Hide VideoCodec.codecSpecific as "private"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/video_coding/codecs/h264/h264_encoder_impl.cc

Issue 2001533003: Refactoring: Hide VideoCodec.codecSpecific as "private" (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Use initializers instead of memset Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« webrtc/common_types.cc ('K') | « webrtc/modules/video_coding/codec_database.cc ('k') | webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/video_coding/codecs/h264/h264_encoder_impl.cc

diff --git a/webrtc/modules/video_coding/codecs/h264/h264_encoder_impl.cc b/webrtc/modules/video_coding/codecs/h264/h264_encoder_impl.cc

index 4d85858a1621aa211eddd4b074365d893f0e58f4..72585a596129617b2b9f8a244e111dc2b4097018 100644

--- a/webrtc/modules/video_coding/codecs/h264/h264_encoder_impl.cc

+++ b/webrtc/modules/video_coding/codecs/h264/h264_encoder_impl.cc

@@ -228,12 +228,10 @@ int32_t H264EncoderImpl::InitEncode(const VideoCodec* codec_settings,

// The following parameters are extension parameters (they're in SEncParamExt,

// not in SEncParamBase).

- init_params.bEnableFrameSkip =

- codec_settings_.codecSpecific.H264.frameDroppingOn;

+ init_params.bEnableFrameSkip = codec_settings_.H264()->frameDroppingOn;

// |uiIntraPeriod| - multiple of GOP size

// |keyFrameInterval| - number of frames

- init_params.uiIntraPeriod =

- codec_settings_.codecSpecific.H264.keyFrameInterval;

+ init_params.uiIntraPeriod = codec_settings_.H264()->keyFrameInterval;

init_params.uiMaxNalSize = 0;

// Threading model: use auto.

// 0: auto (dynamic imp. internal encoder)