Refactoring: Hide VideoCodec.codecSpecific as "private"

webrtc/common_types.cc

 /*
  *  Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
+#include "webrtc/base/checks.h"
 #include "webrtc/common_types.h"
 
 #include <string.h>
 
 namespace webrtc {
 
 int InStream::Rewind() { return -1; }
 
 int OutStream::Rewind() { return -1; }
 
@@ skipping 17 matching lines @@
     : markerBit(false),
       payloadType(0),
       sequenceNumber(0),
       timestamp(0),
       ssrc(0),
       numCSRCs(0),
       paddingLength(0),
       headerLength(0),
       payload_type_frequency(0),
       extension() {
   memset(&arrOfCSRCs, 0, sizeof(arrOfCSRCs));

[tommi, 2016/05/23 17:05:08]

can we get rid of this memset as well?

[hta-webrtc, 2016/05/23 17:19:33]

If the tests still pass....

 }
 
+VideoCodec::VideoCodec()
+    : codecType(kVideoCodecUnknown),
+      plName(),
+      plType(0),
+      width(0),
+      height(0),
+      startBitrate(0),
+      maxBitrate(0),
+      minBitrate(0),
+      targetBitrate(0),
+      maxFramerate(0),
+      qpMax(0),
+      numberOfSimulcastStreams(0),
+      simulcastStream(),
+      spatialLayers(),
+      mode(kRealtimeVideo),
+      codec_specific_() {}
+
+VideoCodecVP8* VideoCodec::VP8() {
+  RTC_DCHECK_EQ(codecType, kVideoCodecVP8);
+  return &codec_specific_.VP8;
+}
+
+const VideoCodecVP8& VideoCodec::VP8() const {
+  RTC_DCHECK_EQ(codecType, kVideoCodecVP8);
+  return codec_specific_.VP8;
+}
+
+VideoCodecVP9* VideoCodec::VP9() {
+  RTC_DCHECK_EQ(codecType, kVideoCodecVP9);
+  return &codec_specific_.VP9;
+}
+
+const VideoCodecVP9& VideoCodec::VP9() const {
+  RTC_DCHECK_EQ(codecType, kVideoCodecVP9);
+  return codec_specific_.VP9;
+}
+
+VideoCodecH264* VideoCodec::H264() {
+  RTC_DCHECK_EQ(codecType, kVideoCodecH264);
+  return &codec_specific_.H264;
+}
+
+const VideoCodecH264& VideoCodec::H264() const {
+  RTC_DCHECK_EQ(codecType, kVideoCodecH264);
+  return codec_specific_.H264;
+}
+
 }  // namespace webrtc