Integrate QualityScaler into VideoToolboxEncoder.

Integrate QualityScaler into VideoToolboxEncoder.

Improves visual quality and framerate during low bitrates by
dropping resolution.

BUG=webrtc:5678
R=tkchin@webrtc.org

Committed: https://crrev.com/e23e7606438f4a143b2de8adcf3d80c06d53717c
Cr-Commit-Position: refs/heads/master@{#12867}

[pbos-webrtc, 2016-05-23 15:25:55]

PTAL, tested using AppRTCDemo at 200k, 300k and 400k hardcoded.

[pbos-webrtc, 2016-05-23 15:27:12]

Description was changed from

==========
Integrate QualityScaler into VideoToolboxEncoder.

Improves visual quality and framerate in low bitrates by dropping
resolution.

BUG=webrtc:5678
R=tkchin@webrtc.org
==========

to

==========
Integrate QualityScaler into VideoToolboxEncoder.

Improves visual quality and framerate for low bitrates by dropping
resolution.

BUG=webrtc:5678
R=tkchin@webrtc.org
==========

[tkchin_webrtc, 2016-05-23 21:26:56]

https://codereview.webrtc.org/2001153003/diff/1/webrtc/modules/video_coding/c...
File webrtc/modules/video_coding/codecs/h264/h264_video_toolbox_encoder.cc
(right):

https://codereview.webrtc.org/2001153003/diff/1/webrtc/modules/video_coding/c...
webrtc/modules/video_coding/codecs/h264/h264_video_toolbox_encoder.cc:261:
RTC_DCHECK(frame.IsZeroSize());
why are frames expected to be zero size?

[pbos-webrtc, 2016-05-23 21:34:39]

Description was changed from

==========
Integrate QualityScaler into VideoToolboxEncoder.

Improves visual quality and framerate for low bitrates by dropping
resolution.

BUG=webrtc:5678
R=tkchin@webrtc.org
==========

to

==========
Integrate QualityScaler into VideoToolboxEncoder.

Improves visual quality and framerate during low bitrates by
dropping resolution.

BUG=webrtc:5678
R=tkchin@webrtc.org
==========

[pbos-webrtc, 2016-05-23 21:35:54]

inverse DCHECK

[pbos-webrtc, 2016-05-23 21:36:25]

PTAL, sorry about that. This was tested with release to see that it performed
OK. :)

https://codereview.webrtc.org/2001153003/diff/1/webrtc/modules/video_coding/c...
File webrtc/modules/video_coding/codecs/h264/h264_video_toolbox_encoder.cc
(right):

https://codereview.webrtc.org/2001153003/diff/1/webrtc/modules/video_coding/c...
webrtc/modules/video_coding/codecs/h264/h264_video_toolbox_encoder.cc:261:
RTC_DCHECK(frame.IsZeroSize());
On 2016/05/23 21:26:56, tkchin_webrtc wrote:
> why are frames expected to be zero size?

Why indeed? :| Inverted it.

[tkchin_webrtc, 2016-05-23 22:05:13]

lgtm

[pbos-webrtc, 2016-05-24 10:18:11]

rebase

[pbos-webrtc, 2016-05-24 10:24:18]

Description was changed from

==========
Integrate QualityScaler into VideoToolboxEncoder.

Improves visual quality and framerate during low bitrates by
dropping resolution.

BUG=webrtc:5678
R=tkchin@webrtc.org
==========

to

==========
Integrate QualityScaler into VideoToolboxEncoder.

Improves visual quality and framerate during low bitrates by
dropping resolution.

BUG=webrtc:5678
R=tkchin@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/e23e7606438f4a143b2de8adc...
==========

[pbos-webrtc, 2016-05-24 10:24:19]

Committed patchset #3 (id:40001) manually as
e23e7606438f4a143b2de8adcf3d80c06d53717c (presubmit successful).

[commit-bot: I haz the power, 2016-05-24 10:24:20]

Description was changed from

==========
Integrate QualityScaler into VideoToolboxEncoder.

Improves visual quality and framerate during low bitrates by
dropping resolution.

BUG=webrtc:5678
R=tkchin@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/e23e7606438f4a143b2de8adc...
==========

to

==========
Integrate QualityScaler into VideoToolboxEncoder.

Improves visual quality and framerate during low bitrates by
dropping resolution.

BUG=webrtc:5678
R=tkchin@webrtc.org

Committed: https://crrev.com/e23e7606438f4a143b2de8adcf3d80c06d53717c
Cr-Commit-Position: refs/heads/master@{#12867}
==========