Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Issue 2001093003: Attempting to fix flaky tests that deal with STUN timeout. (Closed)

Created:
4 years, 7 months ago by Taylor Brandstetter
Modified:
4 years, 7 months ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Attempting to fix flaky tests that deal with STUN timeout. The STUN timeout is 9500ms, and the tests are waiting for 10000ms. The 500ms margin of error is not enough for some bots (such as UBSan). R=pthatcher@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/8fcf4148465cfe458d4f69d5e3f92f34d068dfb2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -3 lines) Patch
M webrtc/p2p/base/stunport_unittest.cc View 1 chunk +5 lines, -1 line 0 comments Download
M webrtc/p2p/base/stunrequest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/p2p/client/basicportallocator_unittest.cc View 2 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Taylor Brandstetter
4 years, 7 months ago (2016-05-23 17:48:55 UTC) #2
pthatcher1
lgtm
4 years, 7 months ago (2016-05-23 17:59:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2001093003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2001093003/1
4 years, 7 months ago (2016-05-23 18:13:45 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/8fcf4148465cfe458d4f69d5e3f92f34d068dfb2 Cr-Commit-Position: refs/heads/master@{#12854}
4 years, 7 months ago (2016-05-23 19:49:39 UTC) #7
Taylor Brandstetter
4 years, 7 months ago (2016-05-23 19:49:41 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8fcf4148465cfe458d4f69d5e3f92f34d068dfb2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698