Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2000103002:
Make Android MediaEncoder loop not run when there aren't any frames left. (Closed)
DescriptionMake Android MediaEncoder loop not run when there aren't any frames left.
This CL makes the loop stop when all frames have been delivered and
start again when a new frame is inserted.
BUG=webrtc:5680
Committed: https://crrev.com/47456803d9c572928f3024cac11872097adf6593
Cr-Commit-Position: refs/heads/master@{#12860}
Patch Set 1 #
Total comments: 1
Patch Set 2 : Use input_frame_infos_ instead of comparing timestamps. #Messages
Total messages: 22 (10 generated)
Description was changed from ========== Make Android MediaEncoder loop not run when there aren't any frames left. This CL makes the loop stop when all frames have been delivered and start again when a new frame is inserted. BUG=webrtc:5680 ========== to ========== Make Android MediaEncoder loop not run when there aren't any frames left. This CL makes the loop stop when all frames have been delivered and start again when a new frame is inserted. BUG=webrtc:5680 ==========
sakal@webrtc.org changed reviewers: + perkj@webrtc.org
On 2016/05/23 07:49:41, sakal wrote: > mailto:sakal@webrtc.org changed reviewers: > + mailto:perkj@webrtc.org Per, can you take a look please?
perkj@webrtc.org changed reviewers: + magjed@webrtc.org
https://codereview.webrtc.org/2000103002/diff/1/webrtc/api/java/jni/androidme... File webrtc/api/java/jni/androidmediaencoder_jni.cc (right): https://codereview.webrtc.org/2000103002/diff/1/webrtc/api/java/jni/androidme... webrtc/api/java/jni/androidmediaencoder_jni.cc:743: if (!output_delivery_loop_running_) { prefer too look at the size of input_frame_infos_. If size=1 , start. if empty()- stop. No need to for extra variable or looking at the timestamps. wdyt?
On 2016/05/23 08:00:20, perkj_webrtc wrote: > https://codereview.webrtc.org/2000103002/diff/1/webrtc/api/java/jni/androidme... > File webrtc/api/java/jni/androidmediaencoder_jni.cc (right): > > https://codereview.webrtc.org/2000103002/diff/1/webrtc/api/java/jni/androidme... > webrtc/api/java/jni/androidmediaencoder_jni.cc:743: if > (!output_delivery_loop_running_) { > prefer too look at the size of input_frame_infos_. If size=1 , start. if > empty()- stop. No need to for extra variable or looking at the timestamps. wdyt? I changed the code to use input_frame_infos_. I think we still need the extra variable though. DeliverOutputFrames() is called from many places in code so we don't know if poll loop has seen that the queue is empty. We might accidentally start the loop twice or more effectively increasing the polling rate.
lgtm
lgtm
The CQ bit was checked by sakal@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2000103002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2000103002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_dbg on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by sakal@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2000103002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2000103002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_dbg on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by sakal@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2000103002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2000103002/20001
Message was sent while issue was closed.
Description was changed from ========== Make Android MediaEncoder loop not run when there aren't any frames left. This CL makes the loop stop when all frames have been delivered and start again when a new frame is inserted. BUG=webrtc:5680 ========== to ========== Make Android MediaEncoder loop not run when there aren't any frames left. This CL makes the loop stop when all frames have been delivered and start again when a new frame is inserted. BUG=webrtc:5680 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Make Android MediaEncoder loop not run when there aren't any frames left. This CL makes the loop stop when all frames have been delivered and start again when a new frame is inserted. BUG=webrtc:5680 ========== to ========== Make Android MediaEncoder loop not run when there aren't any frames left. This CL makes the loop stop when all frames have been delivered and start again when a new frame is inserted. BUG=webrtc:5680 Committed: https://crrev.com/47456803d9c572928f3024cac11872097adf6593 Cr-Commit-Position: refs/heads/master@{#12860} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/47456803d9c572928f3024cac11872097adf6593 Cr-Commit-Position: refs/heads/master@{#12860} |
