Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Side by Side Diff: webrtc/call/call.cc

Issue 2000063003: Update the BWE when the network route changes. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc@master
Patch Set: Add TODO to re-create objects. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | webrtc/modules/bitrate_controller/bitrate_controller_impl.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2013 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2013 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 608 matching lines...) Expand 10 before | Expand all | Expand 10 after
619 auto kv = result.first; 619 auto kv = result.first;
620 bool inserted = result.second; 620 bool inserted = result.second;
621 if (inserted) { 621 if (inserted) {
622 // No need to reset BWE if this is the first time the network connects. 622 // No need to reset BWE if this is the first time the network connects.
623 return; 623 return;
624 } 624 }
625 if (kv->second != network_route) { 625 if (kv->second != network_route) {
626 kv->second = network_route; 626 kv->second = network_route;
627 LOG(LS_INFO) << "Network route changed on transport " << transport_name 627 LOG(LS_INFO) << "Network route changed on transport " << transport_name
628 << ": new local network id " << network_route.local_network_id 628 << ": new local network id " << network_route.local_network_id
629 << " new remote network id " 629 << " new remote network id " << network_route.remote_network_id
630 << network_route.remote_network_id; 630 << " Reset bitrate to "
631 // TODO(holmer): Update the BWE bitrates. 631 << config_.bitrate_config.start_bitrate_bps << "bps";
632 congestion_controller_->ResetBweAndBitrates(
633 config_.bitrate_config.start_bitrate_bps,
634 config_.bitrate_config.min_bitrate_bps,
635 config_.bitrate_config.max_bitrate_bps);
632 } 636 }
633 } 637 }
634 638
635 void Call::UpdateAggregateNetworkState() { 639 void Call::UpdateAggregateNetworkState() {
636 RTC_DCHECK(configuration_thread_checker_.CalledOnValidThread()); 640 RTC_DCHECK(configuration_thread_checker_.CalledOnValidThread());
637 641
638 bool have_audio = false; 642 bool have_audio = false;
639 bool have_video = false; 643 bool have_video = false;
640 { 644 {
641 ReadLockScoped read_lock(*send_crit_); 645 ReadLockScoped read_lock(*send_crit_);
(...skipping 206 matching lines...) Expand 10 before | Expand all | Expand 10 after
848 // thread. Then this check can be enabled. 852 // thread. Then this check can be enabled.
849 // RTC_DCHECK(!configuration_thread_checker_.CalledOnValidThread()); 853 // RTC_DCHECK(!configuration_thread_checker_.CalledOnValidThread());
850 if (RtpHeaderParser::IsRtcp(packet, length)) 854 if (RtpHeaderParser::IsRtcp(packet, length))
851 return DeliverRtcp(media_type, packet, length); 855 return DeliverRtcp(media_type, packet, length);
852 856
853 return DeliverRtp(media_type, packet, length, packet_time); 857 return DeliverRtp(media_type, packet, length, packet_time);
854 } 858 }
855 859
856 } // namespace internal 860 } // namespace internal
857 } // namespace webrtc 861 } // namespace webrtc
OLDNEW
« no previous file with comments | « no previous file | webrtc/modules/bitrate_controller/bitrate_controller_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698