Issue 2000003: Enable Spdy for SxS build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2000003: Enable Spdy for SxS build.

Created:
10 years, 7 months ago by huanr

Modified:
10 years, 7 months ago

Reviewers:
mbelshe, wtc

CC:
chromium-reviews, kuchhal

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Patch Set 4 : '' #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -1 line)			Patch
M	chrome/browser/browser_init.cc	View	3	1 chunk	+7 lines, -0 lines	0 comments	Download
M	chrome/browser/browser_main.cc	View		2 chunks	+3 lines, -1 line	0 comments	Download
M	chrome/installer/util/browser_distribution.h	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/installer/util/browser_distribution.cc	View		1 chunk	+8 lines, -0 lines	0 comments	Download
M	chrome/installer/util/google_chrome_sxs_distribution.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/installer/util/google_chrome_sxs_distribution.cc	View		1 chunk	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

huanr

This change will enable Spdy for SxS build by default. I will hold the check ...

10 years, 7 months ago (2010-05-06 23:12:46 UTC) #1

wtc

LGTM. Please make the change below. http://codereview.chromium.org/2000003/diff/6001/7001 File chrome/browser/browser_init.cc (right): http://codereview.chromium.org/2000003/diff/6001/7001#newcode1021 chrome/browser/browser_init.cc:1021: #if defined(OS_WIN) This ...

10 years, 7 months ago (2010-05-07 00:58:32 UTC) #2

huanr

10 years, 7 months ago (2010-05-07 02:26:45 UTC) #3

On Thu, May 6, 2010 at 5:58 PM, <wtc@chromium.org> wrote:

> LGTM.  Please make the change below.
>
>
> http://codereview.chromium.org/2000003/diff/6001/7001
> File chrome/browser/browser_init.cc (right):
>
> http://codereview.chromium.org/2000003/diff/6001/7001#newcode1021
> chrome/browser/browser_init.cc:1021: #if defined(OS_WIN)
> This should not be limited to Windows.
>
> SxS build only available on Windows now.


>
> http://codereview.chromium.org/2000003/show
>

Expand Messages | Collapse Messages

Issue 2000003: Enable Spdy for SxS build.

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Messages