Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Unified Diff: webrtc/pc/channel.h

Issue 1999853002: Forward the SignalFirstPacketReceived to RtpReceiver. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Add media type to BaseChannel. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« webrtc/api/webrtcsession.cc ('K') | « webrtc/api/webrtcsession.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/pc/channel.h
diff --git a/webrtc/pc/channel.h b/webrtc/pc/channel.h
index d9f5fd6d279f7ce1a046c14c35ac1239a67d6caf..a3bb165daaceb95b4affcdceb07fcba3d5963b58 100644
--- a/webrtc/pc/channel.h
+++ b/webrtc/pc/channel.h
@@ -168,6 +168,8 @@ class BaseChannel
SrtpFilter* srtp_filter() { return &srtp_filter_; }
+ virtual cricket::MediaType MediaType() = 0;
+
protected:
virtual MediaChannel* media_channel() const { return media_channel_; }
// Sets the |transport_channel_| (and |rtcp_transport_channel_|, if |rtcp_| is
@@ -435,6 +437,7 @@ class VoiceChannel : public BaseChannel {
webrtc::RtpParameters GetRtpReceiveParameters_w(uint32_t ssrc) const;
bool SetRtpReceiveParameters_w(uint32_t ssrc,
webrtc::RtpParameters parameters);
+ cricket::MediaType MediaType() override { return cricket::MEDIA_TYPE_AUDIO; }
private:
// overrides from BaseChannel
@@ -518,6 +521,7 @@ class VideoChannel : public BaseChannel {
webrtc::RtpParameters GetRtpReceiveParameters(uint32_t ssrc) const;
bool SetRtpReceiveParameters(uint32_t ssrc,
const webrtc::RtpParameters& parameters);
+ cricket::MediaType MediaType() override { return cricket::MEDIA_TYPE_VIDEO; }
private:
// overrides from BaseChannel
@@ -589,6 +593,7 @@ class DataChannel : public BaseChannel {
sigslot::signal1<bool> SignalReadyToSendData;
// Signal for notifying that the remote side has closed the DataChannel.
sigslot::signal1<uint32_t> SignalStreamClosedRemotely;
+ cricket::MediaType MediaType() override { return cricket::MEDIA_TYPE_DATA; }
pthatcher1 2016/06/08 17:35:56 media_type()
Zhi Huang 2016/06/09 00:37:36 Done.
protected:
// downcasts a MediaChannel.
« webrtc/api/webrtcsession.cc ('K') | « webrtc/api/webrtcsession.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698