Fix iOS GN build and cleanup system_wrappers

Fix iOS GN build and cleanup system_wrappers

Compile fixes for GN on iOS that finally gets our bots green.

Changes to system_wrappers:
* Updated to only use inclusive sources for maintainability
* Add a few missing GN headers.
* Cleanup GYP hack for atomic32_mac.cc
* Renamed changes sources to avoid problems with GYP/GN file
   suffix rules:
  - atomic32_mac.cc -> atomic32_darwin.cc
  - atomic32_posix.cc -> atomic32_non_darwin_unix.cc
See https://code.google.com/p/chromium/codesearch#chromium/src/build/config/BUILDCONFIG.gn&l=325
for details on which extensions can/cannot be used.

BUG=webrtc:5586
NOTRY=True

Committed: https://crrev.com/080a1e3fa60bade0ea19b89606fb0966c82ce2bc
Cr-Commit-Position: refs/heads/master@{#12897}

[kjellander_webrtc, 2016-05-25 16:16:07]

Description was changed from

==========
GN: Fix iOS build.

BUG=webrtc:5586
==========

to

==========
Fix iOS GN build and cleanup system_wrappers

A series of compile fixes for GN on iOS that finally gets our bots green.

system_wrappers changes to avoid problems with GYP/GN file
suffix rules:
* atomic32_mac.cc -> atomic32_darwin.cc 
* atomic32_posix.cc -> atomic32_linux_android.cc 

BUG=webrtc:5586
==========

[kjellander_webrtc, 2016-05-25 16:16:18]

Description was changed from

==========
Fix iOS GN build and cleanup system_wrappers

A series of compile fixes for GN on iOS that finally gets our bots green.

system_wrappers changes to avoid problems with GYP/GN file
suffix rules:
* atomic32_mac.cc -> atomic32_darwin.cc 
* atomic32_posix.cc -> atomic32_linux_android.cc 

BUG=webrtc:5586
==========

to

==========
Fix iOS GN build and cleanup system_wrappers

Compile fixes for GN on iOS that finally gets our bots green.

system_wrappers changes to avoid problems with GYP/GN file
suffix rules:
* atomic32_mac.cc -> atomic32_darwin.cc 
* atomic32_posix.cc -> atomic32_linux_android.cc 

BUG=webrtc:5586
==========

[kjellander_webrtc, 2016-05-25 16:21:57]

Description was changed from

==========
Fix iOS GN build and cleanup system_wrappers

Compile fixes for GN on iOS that finally gets our bots green.

system_wrappers changes to avoid problems with GYP/GN file
suffix rules:
* atomic32_mac.cc -> atomic32_darwin.cc 
* atomic32_posix.cc -> atomic32_linux_android.cc 

BUG=webrtc:5586
==========

to

==========
Fix iOS GN build and cleanup system_wrappers

Compile fixes for GN on iOS that finally gets our bots green.

Changes to system_wrappers:
* Updated to only use inclusive sources for maintainability
* Add a few missing GN headers.
* Cleanup GYP hack for atomic32_mac.cc
* Renamed changes sources to avoid problems with GYP/GN file
   suffix rules:
  - atomic32_mac.cc -> atomic32_darwin.cc 
  - atomic32_posix.cc -> atomic32_linux_android.cc 

BUG=webrtc:5586
==========

[kjellander_webrtc, 2016-05-25 16:21:57]

kjellander@webrtc.org changed reviewers:
+ tkchin@webrtc.org, tommi@webrtc.org

[kjellander_webrtc, 2016-05-25 16:22:53]

Patchset #1 (id:1) has been deleted

[kjellander_webrtc, 2016-05-25 16:23:09]

Patchset #1 (id:20001) has been deleted

[kjellander_webrtc, 2016-05-25 16:23:21]

Patchset #1 (id:40001) has been deleted

[kjellander_webrtc, 2016-05-25 16:23:30]

Patchset #1 (id:60001) has been deleted

[kjellander_webrtc, 2016-05-25 16:23:45]

Patchset #1 (id:80001) has been deleted

[kjellander_webrtc, 2016-05-25 17:03:23]

Description was changed from

==========
Fix iOS GN build and cleanup system_wrappers

Compile fixes for GN on iOS that finally gets our bots green.

Changes to system_wrappers:
* Updated to only use inclusive sources for maintainability
* Add a few missing GN headers.
* Cleanup GYP hack for atomic32_mac.cc
* Renamed changes sources to avoid problems with GYP/GN file
   suffix rules:
  - atomic32_mac.cc -> atomic32_darwin.cc 
  - atomic32_posix.cc -> atomic32_linux_android.cc 

BUG=webrtc:5586
==========

to

==========
Fix iOS GN build and cleanup system_wrappers

Compile fixes for GN on iOS that finally gets our bots green.

Changes to system_wrappers:
* Updated to only use inclusive sources for maintainability
* Add a few missing GN headers.
* Cleanup GYP hack for atomic32_mac.cc
* Renamed changes sources to avoid problems with GYP/GN file
   suffix rules:
  - atomic32_mac.cc -> atomic32_darwin.cc 
  - atomic32_posix.cc -> atomic32_unix.cc 
See
https://code.google.com/p/chromium/codesearch#chromium/src/build/config/BUILD...
for details on which extensions can/cannot be used.

BUG=webrtc:5586
==========

[kjellander_webrtc, 2016-05-25 17:04:27]

Description was changed from

==========
Fix iOS GN build and cleanup system_wrappers

Compile fixes for GN on iOS that finally gets our bots green.

Changes to system_wrappers:
* Updated to only use inclusive sources for maintainability
* Add a few missing GN headers.
* Cleanup GYP hack for atomic32_mac.cc
* Renamed changes sources to avoid problems with GYP/GN file
   suffix rules:
  - atomic32_mac.cc -> atomic32_darwin.cc 
  - atomic32_posix.cc -> atomic32_unix.cc 
See
https://code.google.com/p/chromium/codesearch#chromium/src/build/config/BUILD...
for details on which extensions can/cannot be used.

BUG=webrtc:5586
==========

to

==========
Fix iOS GN build and cleanup system_wrappers

Compile fixes for GN on iOS that finally gets our bots green.

Changes to system_wrappers:
* Updated to only use inclusive sources for maintainability
* Add a few missing GN headers.
* Cleanup GYP hack for atomic32_mac.cc
* Renamed changes sources to avoid problems with GYP/GN file
   suffix rules:
  - atomic32_mac.cc -> atomic32_darwin.cc 
  - atomic32_posix.cc -> atomic32_non_darwin_unix.cc
See
https://code.google.com/p/chromium/codesearch#chromium/src/build/config/BUILD...
for details on which extensions can/cannot be used.

BUG=webrtc:5586
==========

[kjellander_webrtc, 2016-05-25 17:13:08]

A long journey comes to an end! See combined tryjobs for PS#1 and PS#2.

tkchin: webrtc/modules/audio_device/ios/ and webrtc/sdk
tommi: the rest

[kjellander_webrtc, 2016-05-25 17:15:06]

Description was changed from

==========
Fix iOS GN build and cleanup system_wrappers

Compile fixes for GN on iOS that finally gets our bots green.

Changes to system_wrappers:
* Updated to only use inclusive sources for maintainability
* Add a few missing GN headers.
* Cleanup GYP hack for atomic32_mac.cc
* Renamed changes sources to avoid problems with GYP/GN file
   suffix rules:
  - atomic32_mac.cc -> atomic32_darwin.cc 
  - atomic32_posix.cc -> atomic32_non_darwin_unix.cc
See
https://code.google.com/p/chromium/codesearch#chromium/src/build/config/BUILD...
for details on which extensions can/cannot be used.

BUG=webrtc:5586
==========

to

==========
Fix iOS GN build and cleanup system_wrappers

Compile fixes for GN on iOS that finally gets our bots green.

Changes to system_wrappers:
* Updated to only use inclusive sources for maintainability
* Add a few missing GN headers.
* Cleanup GYP hack for atomic32_mac.cc
* Renamed changes sources to avoid problems with GYP/GN file
   suffix rules:
  - atomic32_mac.cc -> atomic32_darwin.cc 
  - atomic32_posix.cc -> atomic32_non_darwin_unix.cc
See
https://code.google.com/p/chromium/codesearch#chromium/src/build/config/BUILD...
for details on which extensions can/cannot be used.

BUG=webrtc:5586
NOTRY=True
==========

[tommi, 2016-05-25 17:33:54]

lgtm

[tkchin_webrtc, 2016-05-25 17:46:21]

lgtm because it's a step forward, but iOS gn does not actually build the right
static library because of missing dependency rule in webrtc/api

https://codereview.webrtc.org/1999723002/diff/120001/webrtc/sdk/BUILD.gn
File webrtc/sdk/BUILD.gn (right):

https://codereview.webrtc.org/1999723002/diff/120001/webrtc/sdk/BUILD.gn#newc...
webrtc/sdk/BUILD.gn:66: # Add these when there's a BUILD.gn for peer connection
APIs
Is there a plan to get GN working for peerconnection files? 
Otherwise this target is deceptive because it builds, but doesn't actually build
what you want.

[kjellander_webrtc, 2016-05-25 17:54:02]

Thanks, I'll look at the missing dependency rule in webrtc/api next.

https://codereview.webrtc.org/1999723002/diff/120001/webrtc/sdk/BUILD.gn
File webrtc/sdk/BUILD.gn (right):

https://codereview.webrtc.org/1999723002/diff/120001/webrtc/sdk/BUILD.gn#newc...
webrtc/sdk/BUILD.gn:66: # Add these when there's a BUILD.gn for peer connection
APIs
On 2016/05/25 17:46:21, tkchin_webrtc wrote:
> Is there a plan to get GN working for peerconnection files? 
> Otherwise this target is deceptive because it builds, but doesn't actually
build
> what you want.

That would be my next thing to look at. Getting these bots green has been the
main priority until now.

[kjellander_webrtc, 2016-05-25 18:00:00]

The CQ bit was checked by kjellander@webrtc.org

[commit-bot: I haz the power, 2016-05-25 18:00:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1999723002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1999723002/120001

[kjellander_webrtc, 2016-05-25 18:00:56]

The CQ bit was unchecked by kjellander@webrtc.org

[kjellander_webrtc, 2016-05-25 18:31:04]

The CQ bit was checked by kjellander@webrtc.org

[commit-bot: I haz the power, 2016-05-25 18:31:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1999723002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1999723002/120001

[commit-bot: I haz the power, 2016-05-25 18:37:15]

Description was changed from

==========
Fix iOS GN build and cleanup system_wrappers

Compile fixes for GN on iOS that finally gets our bots green.

Changes to system_wrappers:
* Updated to only use inclusive sources for maintainability
* Add a few missing GN headers.
* Cleanup GYP hack for atomic32_mac.cc
* Renamed changes sources to avoid problems with GYP/GN file
   suffix rules:
  - atomic32_mac.cc -> atomic32_darwin.cc 
  - atomic32_posix.cc -> atomic32_non_darwin_unix.cc
See
https://code.google.com/p/chromium/codesearch#chromium/src/build/config/BUILD...
for details on which extensions can/cannot be used.

BUG=webrtc:5586
NOTRY=True
==========

to

==========
Fix iOS GN build and cleanup system_wrappers

Compile fixes for GN on iOS that finally gets our bots green.

Changes to system_wrappers:
* Updated to only use inclusive sources for maintainability
* Add a few missing GN headers.
* Cleanup GYP hack for atomic32_mac.cc
* Renamed changes sources to avoid problems with GYP/GN file
   suffix rules:
  - atomic32_mac.cc -> atomic32_darwin.cc 
  - atomic32_posix.cc -> atomic32_non_darwin_unix.cc
See
https://code.google.com/p/chromium/codesearch#chromium/src/build/config/BUILD...
for details on which extensions can/cannot be used.

BUG=webrtc:5586
NOTRY=True
==========

[commit-bot: I haz the power, 2016-05-25 18:37:16]

Committed patchset #2 (id:120001)

[commit-bot: I haz the power, 2016-05-25 18:37:24]

Description was changed from

==========
Fix iOS GN build and cleanup system_wrappers

Compile fixes for GN on iOS that finally gets our bots green.

Changes to system_wrappers:
* Updated to only use inclusive sources for maintainability
* Add a few missing GN headers.
* Cleanup GYP hack for atomic32_mac.cc
* Renamed changes sources to avoid problems with GYP/GN file
   suffix rules:
  - atomic32_mac.cc -> atomic32_darwin.cc 
  - atomic32_posix.cc -> atomic32_non_darwin_unix.cc
See
https://code.google.com/p/chromium/codesearch#chromium/src/build/config/BUILD...
for details on which extensions can/cannot be used.

BUG=webrtc:5586
NOTRY=True
==========

to

==========
Fix iOS GN build and cleanup system_wrappers

Compile fixes for GN on iOS that finally gets our bots green.

Changes to system_wrappers:
* Updated to only use inclusive sources for maintainability
* Add a few missing GN headers.
* Cleanup GYP hack for atomic32_mac.cc
* Renamed changes sources to avoid problems with GYP/GN file
   suffix rules:
  - atomic32_mac.cc -> atomic32_darwin.cc
  - atomic32_posix.cc -> atomic32_non_darwin_unix.cc
See
https://code.google.com/p/chromium/codesearch#chromium/src/build/config/BUILD...
for details on which extensions can/cannot be used.

BUG=webrtc:5586
NOTRY=True

Committed: https://crrev.com/080a1e3fa60bade0ea19b89606fb0966c82ce2bc
Cr-Commit-Position: refs/heads/master@{#12897}
==========

[commit-bot: I haz the power, 2016-05-25 18:37:25]

Patchset 2 (id:??) landed as
https://crrev.com/080a1e3fa60bade0ea19b89606fb0966c82ce2bc
Cr-Commit-Position: refs/heads/master@{#12897}