New rtc dump analyzing tool in Python

webrtc/BUILD.gn

 # Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
 #
 # Use of this source code is governed by a BSD-style license
 # that can be found in the LICENSE file in the root of the source
 # tree. An additional intellectual property rights grant can be found
 # in the file PATENTS.  All contributing project authors may
 # be found in the AUTHORS file in the root of the source tree.
 
 # TODO(kjellander): Rebase this to webrtc/build/common.gypi changes after r6330.
 
@@ skipping 335 matching lines @@
     deps += [ ":rtc_event_log_proto" ]
   }
   if (is_clang && !is_nacl) {
     # Suppress warnings from Chrome's Clang plugins.
     # See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
     configs -= [ "//build/config/clang:find_bad_constructs" ]
   }
 }
 
 if (rtc_enable_protobuf) {
+  group("rtp_analyzer") {

[kjellander_webrtc, 2016/06/13 12:33:31]

I don't think we should expose more targets to Chromium than necessary to avoid
slowing down their build. Can you move these targets into an
if (!build_with_chromium) {
}
block? Or move them into the 
if (rtc_include_tests) {
}
block further down.

+    deps = [
+      ":rtc_event_log_proto",
+      ":rtp_analyzer-copy",
+    ]
+  }
+
+  copy("rtp_analyzer-copy") {
+    sources = [
+      "//tools/py_event_log_analyzer/copy_files.py",

[kjellander_webrtc, 2016/06/13 12:33:31]

Since WebRTC's GN configuration needs to work both in Chromium and WebRTC, we
cannot reference our sources with absolute paths. These would need to be like
"tools/py_event_log_analyzer/copy_files.py" instead.


You can run the patch on a Linux Chromium trybot to find out how/if this breaks.
See https://webrtc.org/contributing/#tryjobs-on-chromium-trybots for details on
that.

[aleloi, 2016/06/14 08:20:49]

But then the path is wrong. The tool is in src/tools, not in src/webrtc/tools.
Should I the whole tool to //webrtc? 

I changed to the relative path "../" in next version.

[aleloi, 2016/06/14 08:29:35]

I tried to follow the instructions to add trybots. The command line one says
"User user:aleloi@webrtc.org cannot add builds to bucket
master.tryserver.chromium.linux". The Rietveld UI says "An error occured". I
made it work by adding a line to the CL description. Now it crashes for another
reason
(https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium...).

+      "//tools/py_event_log_analyzer/misc.py",
+      "//tools/py_event_log_analyzer/pb_parse.py",
+      "//tools/py_event_log_analyzer/rtp_analyzer.py",
+      "//tools/py_event_log_analyzer/rtp_analyzer.sh",
+    ]
+    outputs = [
+      "$root_build_dir/{{source_file_part}}",
+    ]
+  }
+
   source_set("rtc_event_log_parser") {
     sources = [
       "call/rtc_event_log_parser.cc",
       "call/rtc_event_log_parser.h",
     ]
 
     configs += [ ":common_config" ]
     public_configs = [ ":common_inherited_config" ]
 
     deps = [
@@ skipping 228 matching lines @@
       # TODO(tkchin): Cleanup this warning.
       cflags = [ "-Wno-objc-property-no-attribute" ]
 
       # |-ObjC| flag needed to make sure category method implementations
       # are included:
       # https://developer.apple.com/library/mac/qa/qa1490/_index.html
       ldflags = [ "-ObjC" ]
     }
   }
 }