tools/py_event_log_analyzer/rtp_analyzer.sh - Issue 1999113002: New rtc dump analyzing tool in Python

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/py_event_log_analyzer/rtp_analyzer.sh

Issue 1999113002: New rtc dump analyzing tool in Python (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Changed default to py-3 Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 #!/usr/bin/env python	1 #!/bin/sh

2 # Copyright (c) 2011 The WebRTC project authors. All Rights Reserved.	2 # Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.

3 #	3 #

4 # Use of this source code is governed by a BSD-style license	4 # Use of this source code is governed by a BSD-style license

5 # that can be found in the LICENSE file in the root of the source	5 # that can be found in the LICENSE file in the root of the source

6 # tree. An additional intellectual property rights grant can be found	6 # tree. An additional intellectual property rights grant can be found

7 # in the file PATENTS. All contributing project authors may	7 # in the file PATENTS. All contributing project authors may

8 # be found in the AUTHORS file in the root of the source tree.	8 # be found in the AUTHORS file in the root of the source tree.

	9 set -e

	10 cd $(dirname $0)

	11 PYTHONPATH="../../third_party/protobuf/python/"

	12 if [ -z ${PYTHON_EXECUTABLE+x} ]

	13 then

	14 PYTHON_EXECUTABLE=python3

	15 fi

	16 exec $PYTHON_EXECUTABLE "rtp_analyzer.py" $@
	kjellander_webrtc 2016/06/13 12:33:31 I would prefer not having this script. You can alt I would prefer not having this script. You can alter the PYTHONPATH in the Python script itself instead in order to add third_party/protobuf/python. Many scripts to similar things, see https://chromium.googlesource.com/external/webrtc/+/master/tools/autoroller/r... for an example. phoglund 2016/06/13 13:40:48 One problem is that the script doesn't run in pyth Show quoted text On 2016/06/13 12:33:31, kjellander_webrtc wrote: > I would prefer not having this script. You can alter the PYTHONPATH in the > Python script itself instead in order to add third_party/protobuf/python. > Many scripts to similar things, see > https://chromium.googlesource.com/external/webrtc/+/master/tools/autoroller/r... > for an example. One problem is that the script doesn't run in python 2, so I think this can save people some confusion as this script invokes python3 for you. I suggested this script to make it a bit more convenient to run the script. kjellander_webrtc 2016/06/13 14:13:04 Fair enough, let's keep it around. I don't see the Show quoted text On 2016/06/13 13:40:48, phoglund wrote: > On 2016/06/13 12:33:31, kjellander_webrtc wrote: > > I would prefer not having this script. You can alter the PYTHONPATH in the > > Python script itself instead in order to add third_party/protobuf/python. > > Many scripts to similar things, see > > > https://chromium.googlesource.com/external/webrtc/+/master/tools/autoroller/r... > > for an example. > > One problem is that the script doesn't run in python 2, so I think this can save > people some confusion as this script invokes python3 for you. I suggested this > script to make it a bit more convenient to run the script. Fair enough, let's keep it around. I don't see the point of spending time on supporting python3 though - migration is likely far away.
OLD	NEW

« tools/py_event_log_analyzer/rtp_analyzer.py ('K') | « tools/py_event_log_analyzer/rtp_analyzer.py ('k') | webrtc/BUILD.gn » ('j') | webrtc/BUILD.gn » ('J')