Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 1999053002: Reland of Android: Make base interface for camera1 and camera2 (Closed)

Created:
4 years, 7 months ago by magjed_webrtc
Modified:
4 years, 7 months ago
Reviewers:
perkj_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of Android: Make base interface for camera1 and camera2 (patchset #1 id:1 of https://codereview.webrtc.org/1994013004/ ) Reason for revert: Downstream code has been updated. Original issue's description: > Revert of Android: Make base interface for camera1 and camera2 (patchset #1 id:1 of https://codereview.webrtc.org/1994893002/ ) > > Reason for revert: > Still breaks downstream import. > > Original issue's description: > > Reland of Android: Make base interface for camera1 and camera2 (patchset #1 id:1 of https://codereview.webrtc.org/1979583002/ ) > > > > Reason for revert: > > Downstream code has been updated. > > > > Original issue's description: > > > Revert of Android: Make base interface for camera1 and camera2 (patchset #3 id:80001 of https://codereview.webrtc.org/1895483002/ ) > > > > > > Reason for revert: > > > Breaks downstream import. > > > > > > Original issue's description: > > > > Android: Make base interface for camera1 and camera2 > > > > > > > > This CL adds a new interface CameraVideoCapturer that extends VideoCapturer with a switchCamera() function. It also moves moves CameraEventsHandler, CameraStatistics, and CameraSwitchHandler from VideoCapturerAndroid to this new interface. The purpose is to prepare for a camera2 implementation that will use the same interfaces and helper class. > > > > > > > > BUG=webrtc:5519 > > > > > > > > Committed: https://crrev.com/6bdacaddfb18edef1f0cdd778209f6b05a8f9210 > > > > Cr-Commit-Position: refs/heads/master@{#12723} > > > > > > TBR=perkj@webrtc.org > > > # Skipping CQ checks because original CL landed less than 1 days ago. > > > NOPRESUBMIT=true > > > NOTREECHECKS=true > > > NOTRY=true > > > BUG=webrtc:5519 > > > > > > Committed: https://crrev.com/181b5ffdf036427d92929667d9d43bbcff560435 > > > Cr-Commit-Position: refs/heads/master@{#12727} > > > > TBR=perkj@webrtc.org > > # Not skipping CQ checks because original CL landed more than 1 days ago. > > BUG=webrtc:5519 > > > > Committed: https://crrev.com/d269b023bfe1c321798fe9c8dbd631a562914fe1 > > Cr-Commit-Position: refs/heads/master@{#12807} > > TBR=perkj@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:5519 > > Committed: https://crrev.com/bd76607abb712f98c01709f240f147e4bd49df6d > Cr-Commit-Position: refs/heads/master@{#12809} TBR=perkj@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:5519 Committed: https://crrev.com/a8eab866a16dd1177c0c2a5118ec597eacdb225f Cr-Commit-Position: refs/heads/master@{#12830}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+137 lines, -86 lines) Patch
A webrtc/api/java/android/org/webrtc/CameraVideoCapturer.java View 1 chunk +128 lines, -0 lines 0 comments Download
M webrtc/api/java/android/org/webrtc/VideoCapturerAndroid.java View 7 chunks +9 lines, -86 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
magjed_webrtc
Created Reland of Android: Make base interface for camera1 and camera2
4 years, 7 months ago (2016-05-20 12:19:47 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1999053002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1999053002/1
4 years, 7 months ago (2016-05-20 12:19:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1999053002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1999053002/1
4 years, 7 months ago (2016-05-20 12:31:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1999053002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1999053002/1
4 years, 7 months ago (2016-05-20 13:01:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1999053002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1999053002/1
4 years, 7 months ago (2016-05-20 13:31:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1999053002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1999053002/1
4 years, 7 months ago (2016-05-20 14:01:13 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_rel on ...
4 years, 7 months ago (2016-05-20 14:20:32 UTC) #8
magjed_webrtc
Committed patchset #1 (id:1) manually as a8eab866a16dd1177c0c2a5118ec597eacdb225f (presubmit successful).
4 years, 7 months ago (2016-05-20 15:22:31 UTC) #11
commit-bot: I haz the power
4 years, 7 months ago (2016-05-20 15:22:34 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a8eab866a16dd1177c0c2a5118ec597eacdb225f
Cr-Commit-Position: refs/heads/master@{#12830}

Powered by Google App Engine
This is Rietveld 408576698