Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(475)

Unified Diff: webrtc/p2p/base/stunport.cc

Issue 1998813002: Fixing the behavior of the candidate filter with pooled candidates. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Revising a comment and changing order of member variable declaration Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/p2p/base/stunport.cc
diff --git a/webrtc/p2p/base/stunport.cc b/webrtc/p2p/base/stunport.cc
index 8ed8c44887238ca5e260113783a96e21e6731a76..300301813c053d9d428ada4d9a91bf027b1ca320 100644
--- a/webrtc/p2p/base/stunport.cc
+++ b/webrtc/p2p/base/stunport.cc
@@ -457,10 +457,7 @@ void UDPPort::OnStunBindingRequestSucceeded(
rtc::SocketAddress related_address = socket_->GetLocalAddress();
// If we can't stamp the related address correctly, empty it to avoid leak.
- if (!MaybeSetDefaultLocalAddress(&related_address) ||
- !(candidate_filter() & CF_HOST)) {
- // If candidate filter doesn't have CF_HOST specified, empty raddr to
- // avoid local address leakage.
+ if (!MaybeSetDefaultLocalAddress(&related_address)) {
related_address = rtc::EmptySocketAddressWithFamily(
related_address.family());
}

Powered by Google App Engine
This is Rietveld 408576698