Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Unified Diff: webrtc/p2p/base/port.h

Issue 1998813002: Fixing the behavior of the candidate filter with pooled candidates. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Revising a comment and changing order of member variable declaration Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/p2p/base/port.h
diff --git a/webrtc/p2p/base/port.h b/webrtc/p2p/base/port.h
index 937f3cd0284f058e12fc6a47848ac0ad8ec98204..eef9778e546f7b6bee16a2d709381a14ec075349 100644
--- a/webrtc/p2p/base/port.h
+++ b/webrtc/p2p/base/port.h
@@ -293,9 +293,6 @@ class Port : public PortInterface, public rtc::MessageHandler,
// Returns the index of the new local candidate.
size_t AddPrflxCandidate(const Candidate& local);
- void set_candidate_filter(uint32_t candidate_filter) {
- candidate_filter_ = candidate_filter;
- }
int16_t network_cost() const { return network_cost_; }
protected:
@@ -347,8 +344,6 @@ class Port : public PortInterface, public rtc::MessageHandler,
return rtc::DSCP_NO_CHANGE;
}
- uint32_t candidate_filter() { return candidate_filter_; }
-
private:
void Construct();
// Called when one of our connections deletes itself.
@@ -394,12 +389,6 @@ class Port : public PortInterface, public rtc::MessageHandler,
std::string user_agent_;
rtc::ProxyInfo proxy_;
- // Candidate filter is pushed down to Port such that each Port could
- // make its own decision on how to create candidates. For example,
- // when IceTransportsType is set to relay, both RelayPort and
- // TurnPort will hide raddr to avoid local address leakage.
- uint32_t candidate_filter_;
-
// A virtual cost perceived by the user, usually based on the network type
// (WiFi. vs. Cellular). It takes precedence over the priority when
// comparing two connections.

Powered by Google App Engine
This is Rietveld 408576698