[rtcp] App::Parse updated not to use RTCPUtility,

[rtcp] App::Parse updated not to use RTCPUtility,
maximum allowed sized raised from limited by physical udp packet size to
limited by theoritical maximum rtcp packet size.

BUG=webrtc:5260
R=åsapersson

Committed: https://crrev.com/2874ed5709e826669a1b7e1a12982071f59a9491
Cr-Commit-Position: refs/heads/master@{#13532}

[åsapersson, 2016-07-26 09:58:15]

https://codereview.webrtc.org/1998633002/diff/1/webrtc/modules/rtp_rtcp/sourc...
File webrtc/modules/rtp_rtcp/source/rtcp_packet/app.cc (right):

https://codereview.webrtc.org/1998633002/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtcp_packet/app.cc:37: if
(packet.payload_size_bytes() < kAppBaseLength) {
is payload_size_bytes multiple of 4 here or should it be validated?

https://codereview.webrtc.org/1998633002/diff/1/webrtc/modules/rtp_rtcp/sourc...
File webrtc/modules/rtp_rtcp/source/rtcp_packet/app_unittest.cc (right):

https://codereview.webrtc.org/1998633002/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtcp_packet/app_unittest.cc:28: constexpr uint8_t
kPacketWithoutData[] = {0x9e,  204, 0x00, 0x02,
App::kPacketType

https://codereview.webrtc.org/1998633002/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtcp_packet/app_unittest.cc:31: constexpr uint8_t
kPacketWithData[] = {0x9e,  204, 0x00, 0x04,
App::kPacketType

https://codereview.webrtc.org/1998633002/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtcp_packet/app_unittest.cc:76: 
maybe check kSenderSsrc

[danilchap, 2016-07-26 11:37:02]

https://codereview.webrtc.org/1998633002/diff/1/webrtc/modules/rtp_rtcp/sourc...
File webrtc/modules/rtp_rtcp/source/rtcp_packet/app.cc (right):

https://codereview.webrtc.org/1998633002/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtcp_packet/app.cc:37: if
(packet.payload_size_bytes() < kAppBaseLength) {
On 2016/07/26 09:58:15, åsapersson wrote:
> is payload_size_bytes multiple of 4 here or should it be validated?
Good point.
It is possible to create a packet where payload size is not multiple of 4 and
that would then create an inconsistent App object where data size is not 32bit
aligned.
Test & validation added.

https://codereview.webrtc.org/1998633002/diff/1/webrtc/modules/rtp_rtcp/sourc...
File webrtc/modules/rtp_rtcp/source/rtcp_packet/app_unittest.cc (right):

https://codereview.webrtc.org/1998633002/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtcp_packet/app_unittest.cc:28: constexpr uint8_t
kPacketWithoutData[] = {0x9e,  204, 0x00, 0x02,
On 2016/07/26 09:58:15, åsapersson wrote:
> App::kPacketType

Done.
First byte expanded too.

https://codereview.webrtc.org/1998633002/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtcp_packet/app_unittest.cc:31: constexpr uint8_t
kPacketWithData[] = {0x9e,  204, 0x00, 0x04,
On 2016/07/26 09:58:15, åsapersson wrote:
> App::kPacketType

Done.

https://codereview.webrtc.org/1998633002/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtcp_packet/app_unittest.cc:76: 
On 2016/07/26 09:58:15, åsapersson wrote:
> maybe check kSenderSsrc

Done.

[åsapersson, 2016-07-26 12:03:24]

lgtm

[danilchap, 2016-07-26 12:27:15]

The CQ bit was checked by danilchap@webrtc.org

[commit-bot: I haz the power, 2016-07-26 12:27:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-07-26 13:40:33]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-26 13:40:42]

Description was changed from

==========
[rtcp] App::Parse updated not to use RTCPUtility,
maximum allowed sized raised from limited by physical udp packet size to
limited by theoritical maximum rtcp packet size.

BUG=webrtc:5260
R=åsapersson
==========

to

==========
[rtcp] App::Parse updated not to use RTCPUtility,
maximum allowed sized raised from limited by physical udp packet size to
limited by theoritical maximum rtcp packet size.

BUG=webrtc:5260
R=åsapersson

Committed: https://crrev.com/2874ed5709e826669a1b7e1a12982071f59a9491
Cr-Commit-Position: refs/heads/master@{#13532}
==========

[commit-bot: I haz the power, 2016-07-26 13:40:43]

Patchset 2 (id:??) landed as
https://crrev.com/2874ed5709e826669a1b7e1a12982071f59a9491
Cr-Commit-Position: refs/heads/master@{#13532}