Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Unified Diff: webrtc/examples/androidapp/src/org/appspot/apprtc/AppRTCClient.java

Issue 1998483003: General cleanup on AppRTC Android Demo codebase (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Remove unused string that was accidentally added. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/examples/androidapp/src/org/appspot/apprtc/AppRTCClient.java
diff --git a/webrtc/examples/androidapp/src/org/appspot/apprtc/AppRTCClient.java b/webrtc/examples/androidapp/src/org/appspot/apprtc/AppRTCClient.java
index f9cb67bd02a01ad25e7b743cec910c3cc96239eb..0b16db8c5e5fa0e02bf0c8017bfe37c0bebe53c2 100644
--- a/webrtc/examples/androidapp/src/org/appspot/apprtc/AppRTCClient.java
+++ b/webrtc/examples/androidapp/src/org/appspot/apprtc/AppRTCClient.java
@@ -24,7 +24,7 @@ public interface AppRTCClient {
/**
* Struct holding the connection parameters of an AppRTC room.
*/
- public static class RoomConnectionParameters {
+ class RoomConnectionParameters {
public final String roomUrl;
public final String roomId;
public final boolean loopback;
@@ -41,37 +41,37 @@ public interface AppRTCClient {
* parameters. Once connection is established onConnectedToRoom()
* callback with room parameters is invoked.
*/
- public void connectToRoom(RoomConnectionParameters connectionParameters);
+ void connectToRoom(RoomConnectionParameters connectionParameters);
/**
* Send offer SDP to the other participant.
*/
- public void sendOfferSdp(final SessionDescription sdp);
+ void sendOfferSdp(final SessionDescription sdp);
/**
* Send answer SDP to the other participant.
*/
- public void sendAnswerSdp(final SessionDescription sdp);
+ void sendAnswerSdp(final SessionDescription sdp);
/**
* Send Ice candidate to the other participant.
*/
- public void sendLocalIceCandidate(final IceCandidate candidate);
+ void sendLocalIceCandidate(final IceCandidate candidate);
/**
* Send removed ICE candidates to the other participant.
*/
- public void sendLocalIceCandidateRemovals(final IceCandidate[] candidates);
+ void sendLocalIceCandidateRemovals(final IceCandidate[] candidates);
/**
* Disconnect from room.
*/
- public void disconnectFromRoom();
+ void disconnectFromRoom();
/**
* Struct holding the signaling parameters of an AppRTC room.
*/
- public static class SignalingParameters {
+ class SignalingParameters {
public final List<PeerConnection.IceServer> iceServers;
public final boolean initiator;
public final String clientId;
@@ -100,36 +100,36 @@ public interface AppRTCClient {
*
* <p>Methods are guaranteed to be invoked on the UI thread of |activity|.
*/
- public static interface SignalingEvents {
+ interface SignalingEvents {
/**
* Callback fired once the room's signaling parameters
* SignalingParameters are extracted.
*/
- public void onConnectedToRoom(final SignalingParameters params);
+ void onConnectedToRoom(final SignalingParameters params);
/**
* Callback fired once remote SDP is received.
*/
- public void onRemoteDescription(final SessionDescription sdp);
+ void onRemoteDescription(final SessionDescription sdp);
/**
* Callback fired once remote Ice candidate is received.
*/
- public void onRemoteIceCandidate(final IceCandidate candidate);
+ void onRemoteIceCandidate(final IceCandidate candidate);
/**
* Callback fired once remote Ice candidate removals are received.
*/
- public void onRemoteIceCandidatesRemoved(final IceCandidate[] candidates);
+ void onRemoteIceCandidatesRemoved(final IceCandidate[] candidates);
/**
* Callback fired once channel is closed.
*/
- public void onChannelClose();
+ void onChannelClose();
/**
* Callback fired once channel error happened.
*/
- public void onChannelError(final String description);
+ void onChannelError(final String description);
}
}

Powered by Google App Engine
This is Rietveld 408576698