Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Issue 1998483003: General cleanup on AppRTC Android Demo codebase (Closed)

Created:
4 years, 7 months ago by sakal
Modified:
4 years, 7 months ago
Reviewers:
magjed_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

General cleanup on AppRTC Android Demo codebase Committed: https://crrev.com/7268f28520a4b011abb26e4fffa0dde7fcc30f64 Cr-Commit-Position: refs/heads/master@{#12828}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Remove unused string that was accidentally added. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -85 lines) Patch
M webrtc/examples/androidapp/res/layout/activity_call.xml View 1 chunk +3 lines, -4 lines 0 comments Download
M webrtc/examples/androidapp/res/layout/fragment_call.xml View 2 chunks +4 lines, -5 lines 0 comments Download
M webrtc/examples/androidapp/res/layout/fragment_hud.xml View 2 chunks +4 lines, -5 lines 0 comments Download
M webrtc/examples/androidapp/res/values/strings.xml View 1 2 chunks +4 lines, -2 lines 0 comments Download
M webrtc/examples/androidapp/src/org/appspot/apprtc/AppRTCAudioManager.java View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/examples/androidapp/src/org/appspot/apprtc/AppRTCClient.java View 3 chunks +15 lines, -15 lines 0 comments Download
M webrtc/examples/androidapp/src/org/appspot/apprtc/AppRTCProximitySensor.java View 3 chunks +12 lines, -12 lines 0 comments Download
M webrtc/examples/androidapp/src/org/appspot/apprtc/CallFragment.java View 1 chunk +5 lines, -5 lines 0 comments Download
M webrtc/examples/androidapp/src/org/appspot/apprtc/CaptureQualityController.java View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/examples/androidapp/src/org/appspot/apprtc/ConnectActivity.java View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/examples/androidapp/src/org/appspot/apprtc/CpuMonitor.java View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/examples/androidapp/src/org/appspot/apprtc/PeerConnectionClient.java View 5 chunks +14 lines, -21 lines 0 comments Download
M webrtc/examples/androidapp/src/org/appspot/apprtc/RoomParametersFetcher.java View 1 chunk +3 lines, -3 lines 0 comments Download
M webrtc/examples/androidapp/src/org/appspot/apprtc/WebSocketChannelClient.java View 5 chunks +6 lines, -7 lines 0 comments Download
M webrtc/examples/androidapp/src/org/appspot/apprtc/util/AsyncHttpURLConnection.java View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 20 (10 generated)
sakal
Madjed, please take a look.
4 years, 7 months ago (2016-05-19 14:28:31 UTC) #2
magjed_webrtc
Nice, lgtm. https://codereview.webrtc.org/1998483003/diff/1/webrtc/examples/androidapp/src/org/appspot/apprtc/AppRTCAudioManager.java File webrtc/examples/androidapp/src/org/appspot/apprtc/AppRTCAudioManager.java (left): https://codereview.webrtc.org/1998483003/diff/1/webrtc/examples/androidapp/src/org/appspot/apprtc/AppRTCAudioManager.java#oldcode243 webrtc/examples/androidapp/src/org/appspot/apprtc/AppRTCAudioManager.java:243: boolean hasWiredHeadset = (state == STATE_PLUGGED) ? ...
4 years, 7 months ago (2016-05-20 08:03:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1998483003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1998483003/1
4 years, 7 months ago (2016-05-20 08:04:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1998483003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1998483003/20001
4 years, 7 months ago (2016-05-20 08:16:14 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_rel on ...
4 years, 7 months ago (2016-05-20 10:16:38 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1998483003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1998483003/20001
4 years, 7 months ago (2016-05-20 10:39:31 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
4 years, 7 months ago (2016-05-20 12:40:04 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1998483003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1998483003/20001
4 years, 7 months ago (2016-05-20 13:23:37 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-20 13:28:38 UTC) #18
commit-bot: I haz the power
4 years, 7 months ago (2016-05-20 13:28:42 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7268f28520a4b011abb26e4fffa0dde7fcc30f64
Cr-Commit-Position: refs/heads/master@{#12828}

Powered by Google App Engine
This is Rietveld 408576698