Improved error checking for file errors in RtcEventLog.

Improved error checking for file errors in RtcEventLog.

Committed: https://crrev.com/f1a9a545fffeb90cec3144d57c5d7caea5d06804
Cr-Commit-Position: refs/heads/master@{#12862}

[terelius, 2016-05-23 11:29:04]

terelius@webrtc.org changed reviewers:
+ ivoc@webrtc.org, pbos@webrtc.org

[terelius, 2016-05-23 11:29:05]

PTAL

[pbos-webrtc, 2016-05-23 11:59:11]

lgtm, remove unnecessary bools etc

https://codereview.webrtc.org/1997393002/diff/1/webrtc/call/rtc_event_log_hel...
File webrtc/call/rtc_event_log_helper_thread.cc (right):

https://codereview.webrtc.org/1997393002/diff/1/webrtc/call/rtc_event_log_hel...
webrtc/call/rtc_event_log_helper_thread.cc:148: LOG(LS_WARNING) << "FileWrapper
failed to write WebRtcEventLog file.";
LS_ERROR

https://codereview.webrtc.org/1997393002/diff/1/webrtc/call/rtc_event_log_hel...
webrtc/call/rtc_event_log_helper_thread.cc:190: bool success =
file_->Write(output_string_.data(), output_string_.size());
remove temporary bool

https://codereview.webrtc.org/1997393002/diff/1/webrtc/call/rtc_event_log_hel...
webrtc/call/rtc_event_log_helper_thread.cc:192: LOG(LS_WARNING) << "FileWrapper
failed to write WebRtcEventLog file.";
LS_ERROR

https://codereview.webrtc.org/1997393002/diff/1/webrtc/call/rtc_event_log_hel...
webrtc/call/rtc_event_log_helper_thread.cc:221: bool success =
file_->Write(output_string_.data(), output_string_.size());
remove bool here and everywhere it's not used after the if()

https://codereview.webrtc.org/1997393002/diff/1/webrtc/call/rtc_event_log_hel...
webrtc/call/rtc_event_log_helper_thread.cc:223: LOG(LS_WARNING) << "FileWrapper
failed to write WebRtcEventLog file.";
LS_ERROR

[ivoc, 2016-05-24 07:34:41]

LGTM, but +1 on pbos comments.

[terelius, 2016-05-24 08:02:14]

The CQ bit was checked by terelius@webrtc.org

[terelius, 2016-05-24 08:02:15]

The patchset sent to the CQ was uploaded after l-g-t-m from pbos@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1997393002/#ps20001 (title:
"Comments from pbos")

[commit-bot: I haz the power, 2016-05-24 08:02:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1997393002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1997393002/20001

[commit-bot: I haz the power, 2016-05-24 08:04:03]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-24 08:04:10]

Description was changed from

==========
Improved error checking for file errors in RtcEventLog.
==========

to

==========
Improved error checking for file errors in RtcEventLog.

Committed: https://crrev.com/f1a9a545fffeb90cec3144d57c5d7caea5d06804
Cr-Commit-Position: refs/heads/master@{#12862}
==========

[commit-bot: I haz the power, 2016-05-24 08:04:12]

Patchset 2 (id:??) landed as
https://crrev.com/f1a9a545fffeb90cec3144d57c5d7caea5d06804
Cr-Commit-Position: refs/heads/master@{#12862}