Fire a signal when the transport channel state changes

Fire a signal when the transport channel state changes

This fixes an issue that sometimes the transport channel state changes but
the transportcontroller is not notified.

BUG=5907
R=deadbeef@webrtc.org, pthatcher@webrtc.org

Committed: https://crrev.com/1590c3937c77ebe878a04142eceee7e330d4fe38
Cr-Commit-Position: refs/heads/master@{#12880}

[honghaiz3, 2016-05-19 22:30:23]

Patchset #1 (id:1) has been deleted

[honghaiz3, 2016-05-19 22:37:16]

Patchset #1 (id:20001) has been deleted

[honghaiz3, 2016-05-19 22:38:25]

honghaiz@webrtc.org changed reviewers:
+ deadbeef@webrtc.org, pthacher@webrtc.org

[honghaiz3, 2016-05-19 22:38:58]

Description was changed from

==========
Fire a signal when the transport channel state changes

This fixes an issue that sometimes the transport channel state changes but
the transportcontrolled is not notified.

BUG=5907
==========

to

==========
Fire a signal when the transport channel state changes

This fixes an issue that sometimes the transport channel state changes but
the transportcontroller is not notified.

BUG=5907
==========

[Taylor Brandstetter, 2016-05-19 22:50:07]

lgtm (after you change the log message). This is something I've been planning on
doing for a while; I even almost had a CL ready to do it, before my workstation
died). So thanks!

https://codereview.webrtc.org/1996693002/diff/40001/webrtc/p2p/base/transport...
File webrtc/p2p/base/transportcontroller.cc (right):

https://codereview.webrtc.org/1996693002/diff/40001/webrtc/p2p/base/transport...
webrtc/p2p/base/transportcontroller.cc:598: LOG(LS_INFO) <<
channel->transport_name() << " TransportChannel "
Update the log message

[honghaiz3, 2016-05-19 22:58:23]

https://codereview.webrtc.org/1996693002/diff/40001/webrtc/p2p/base/transport...
File webrtc/p2p/base/transportcontroller.cc (right):

https://codereview.webrtc.org/1996693002/diff/40001/webrtc/p2p/base/transport...
webrtc/p2p/base/transportcontroller.cc:598: LOG(LS_INFO) <<
channel->transport_name() << " TransportChannel "
On 2016/05/19 22:50:07, Taylor Brandstetter wrote:
> Update the log message

Done.

[pthatcher1, 2016-05-24 17:44:40]

pthatcher@webrtc.org changed reviewers:
+ pthatcher@webrtc.org
- pthacher@webrtc.org

[pthatcher1, 2016-05-24 17:47:08]

lgtm, assuming you change the name of the signal

https://codereview.webrtc.org/1996693002/diff/60001/webrtc/p2p/base/p2ptransp...
File webrtc/p2p/base/p2ptransportchannel.cc (right):

https://codereview.webrtc.org/1996693002/diff/60001/webrtc/p2p/base/p2ptransp...
webrtc/p2p/base/p2ptransportchannel.cc:1216: SignalChannelStateChanged(this);
This should be named SignalStateChanged.

[honghaiz3, 2016-05-24 18:03:49]

The CQ bit was checked by honghaiz@webrtc.org

[honghaiz3, 2016-05-24 18:03:49]

The patchset sent to the CQ was uploaded after l-g-t-m from deadbeef@webrtc.org,
pthatcher@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1996693002/#ps80001 (title:
"Changed signal name to SignalStateChanged")

[commit-bot: I haz the power, 2016-05-24 18:03:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1996693002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1996693002/80001

[commit-bot: I haz the power, 2016-05-24 20:04:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-24 20:04:42]

Try jobs failed on following builders:
  android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[honghaiz3, 2016-05-24 20:14:48]

https://codereview.webrtc.org/1996693002/diff/60001/webrtc/p2p/base/p2ptransp...
File webrtc/p2p/base/p2ptransportchannel.cc (right):

https://codereview.webrtc.org/1996693002/diff/60001/webrtc/p2p/base/p2ptransp...
webrtc/p2p/base/p2ptransportchannel.cc:1216: SignalChannelStateChanged(this);
On 2016/05/24 17:47:07, pthatcher1 wrote:
> This should be named SignalStateChanged.

Done.

[honghaiz3, 2016-05-24 20:15:22]

Description was changed from

==========
Fire a signal when the transport channel state changes

This fixes an issue that sometimes the transport channel state changes but
the transportcontroller is not notified.

BUG=5907
==========

to

==========
Fire a signal when the transport channel state changes

This fixes an issue that sometimes the transport channel state changes but
the transportcontroller is not notified.

BUG=5907
R=deadbeef@webrtc.org, pthatcher@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/1590c3937c77ebe878a04142e...
==========

[commit-bot: I haz the power, 2016-05-24 20:15:22]

Description was changed from

==========
Fire a signal when the transport channel state changes

This fixes an issue that sometimes the transport channel state changes but
the transportcontroller is not notified.

BUG=5907
R=deadbeef@webrtc.org, pthatcher@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/1590c3937c77ebe878a04142e...
==========

to

==========
Fire a signal when the transport channel state changes

This fixes an issue that sometimes the transport channel state changes but
the transportcontroller is not notified.

BUG=5907
R=deadbeef@webrtc.org, pthatcher@webrtc.org

Committed: https://crrev.com/1590c3937c77ebe878a04142eceee7e330d4fe38
Cr-Commit-Position: refs/heads/master@{#12880}
==========

[commit-bot: I haz the power, 2016-05-24 20:15:23]

Patchset 3 (id:??) landed as
https://crrev.com/1590c3937c77ebe878a04142eceee7e330d4fe38
Cr-Commit-Position: refs/heads/master@{#12880}

[honghaiz3, 2016-05-24 20:15:24]

Committed patchset #3 (id:80001) manually as
1590c3937c77ebe878a04142eceee7e330d4fe38 (presubmit successful).