Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1995343002:
android: Eliminate use of IsZeroSize method (Closed)
|
Created:
4 years, 7 months ago by nisse-webrtc Modified:
4 years, 7 months ago CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com Base URL:
https://chromium.googlesource.com/external/webrtc.git@master Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptionEliminate use of IsZeroSize method
Check for dropped frames by instead checking the
frame_buffer pointer directly.
Also add RTC_DCHECK to verify that a webrtc::VideoFrame never
has video_frame_buffer_ set to nullptr (except by the default
constructor).
BUG=webrtc:5682
Committed: https://crrev.com/94cd3fa03ad47debf1d462053e90771d20595e36
Cr-Commit-Position: refs/heads/master@{#12859}
Patch Set 1 #Patch Set 2 : Fix for the case of dropped frames. #Patch Set 3 : Rebase. #
Messages
Total messages: 35 (16 generated)
The CQ bit was checked by nisse@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1995343002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1995343002/1
nisse@webrtc.org changed reviewers: + magjed@webrtc.org, perkj@webrtc.org
I want to delete the IsZeroSize method. This was the first easy easy use to get rid of.
its used here for dropped frames.
The CQ bit was checked by nisse@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1995343002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1995343002/20001
Description was changed from ========== android: Drop IsZeroSize call which can never be true. Also add RTC_DCHECK to verify that a webrtc::VideoFrame never has video_frame_buffer_ set to nullptr (except by the default constructor). BUG=webrtc:5682 ========== to ========== Eliminate use of IsZeroSize method Check for dropped frames by instead checking the frame_buffer pointer directly. Also add RTC_DCHECK to verify that a webrtc::VideoFrame never has video_frame_buffer_ set to nullptr (except by the default constructor). BUG=webrtc:5682 ==========
On 2016/05/20 13:17:04, perkj_webrtc wrote: > its used here for dropped frames. Done in a different way now. Hopefully behavior is unchanged.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
On 2016/05/20 15:28:16, commit-bot: I haz the power wrote: > Dry run: Try jobs failed on following builders: > android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL) lgtm
lgtm
The CQ bit was checked by nisse@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1995343002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1995343002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: presubmit on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/5749)
nisse@webrtc.org changed reviewers: + pbos@webrtc.org
pbos: Owner's approval needed for the change to webrtc::VideoFrame. I add some DCHECKS to ban ever setting video_frame_buffer_ to null.
lgtm
The CQ bit was checked by nisse@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1995343002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1995343002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_dbg on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by nisse@webrtc.org
The patchset sent to the CQ was uploaded after l-g-t-m from magjed@webrtc.org, pbos@webrtc.org, perkj@webrtc.org Link to the patchset: https://codereview.webrtc.org/1995343002/#ps40001 (title: "Rebase.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1995343002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1995343002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_dbg on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by nisse@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1995343002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1995343002/40001
Message was sent while issue was closed.
Description was changed from ========== Eliminate use of IsZeroSize method Check for dropped frames by instead checking the frame_buffer pointer directly. Also add RTC_DCHECK to verify that a webrtc::VideoFrame never has video_frame_buffer_ set to nullptr (except by the default constructor). BUG=webrtc:5682 ========== to ========== Eliminate use of IsZeroSize method Check for dropped frames by instead checking the frame_buffer pointer directly. Also add RTC_DCHECK to verify that a webrtc::VideoFrame never has video_frame_buffer_ set to nullptr (except by the default constructor). BUG=webrtc:5682 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Eliminate use of IsZeroSize method Check for dropped frames by instead checking the frame_buffer pointer directly. Also add RTC_DCHECK to verify that a webrtc::VideoFrame never has video_frame_buffer_ set to nullptr (except by the default constructor). BUG=webrtc:5682 ========== to ========== Eliminate use of IsZeroSize method Check for dropped frames by instead checking the frame_buffer pointer directly. Also add RTC_DCHECK to verify that a webrtc::VideoFrame never has video_frame_buffer_ set to nullptr (except by the default constructor). BUG=webrtc:5682 Committed: https://crrev.com/94cd3fa03ad47debf1d462053e90771d20595e36 Cr-Commit-Position: refs/heads/master@{#12859} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/94cd3fa03ad47debf1d462053e90771d20595e36 Cr-Commit-Position: refs/heads/master@{#12859} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
