Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1994623003:
Reduce flakyness of timing dependent tests for TestFrameBuffer2.*. (Closed)
|
Created:
4 years, 7 months ago by philipel Modified:
4 years, 7 months ago Reviewers:
stefan-webrtc CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman Base URL:
https://chromium.googlesource.com/external/webrtc.git@master Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptionReduce flakyness of timing dependent tests for TestFrameBuffer2.*.
BUG=
R=stefan@webrtc.org
Committed: https://chromium.googlesource.com/external/webrtc/+/6e8224f4ab285f409e431aa836f9d1027de057d7
Patch Set 1 #
Total comments: 1
Patch Set 2 : Disable timing dependent unittests on asan/msan trybots. #
Total comments: 1
Patch Set 3 : Grouped all timing/non-timing dependent tests together. #Messages
Total messages: 21 (11 generated)
Description was changed from ========== Reduce flakyness of timing dependent tests for TestFrameBuffer2.*. NOPRESUBMIT=true NOTRY=true BUG= ========== to ========== Reduce flakyness of timing dependent tests for TestFrameBuffer2.*. BUG= ==========
philipel@webrtc.org changed reviewers: + stefan@webrtc.org
The CQ bit was checked by philipel@webrtc.org
The CQ bit was unchecked by philipel@webrtc.org
The CQ bit was checked by philipel@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1994623003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1994623003/1
lgtm https://codereview.webrtc.org/1994623003/diff/1/webrtc/modules/video_coding/f... File webrtc/modules/video_coding/frame_buffer2_unittest.cc (right): https://codereview.webrtc.org/1994623003/diff/1/webrtc/modules/video_coding/f... webrtc/modules/video_coding/frame_buffer2_unittest.cc:197: ExtractFrame(50); Maybe name these constants to make it more readable.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_asan on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/mac_asan/builds/14739)
lgtm with one comment addressed. https://codereview.webrtc.org/1994623003/diff/20001/webrtc/modules/video_codi... File webrtc/modules/video_coding/frame_buffer2_unittest.cc (right): https://codereview.webrtc.org/1994623003/diff/20001/webrtc/modules/video_codi... webrtc/modules/video_coding/frame_buffer2_unittest.cc:191: } Maybe move this down so all non timing dependent tests are kept separate.
The CQ bit was checked by philipel@webrtc.org
The patchset sent to the CQ was uploaded after l-g-t-m from stefan@webrtc.org Link to the patchset: https://codereview.webrtc.org/1994623003/#ps40001 (title: "Grouped all timing/non-timing dependent tests together.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1994623003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1994623003/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
Description was changed from ========== Reduce flakyness of timing dependent tests for TestFrameBuffer2.*. BUG= ========== to ========== Reduce flakyness of timing dependent tests for TestFrameBuffer2.*. BUG= R=stefan@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/6e8224f4ab285f409e431aa83... ==========
Message was sent while issue was closed.
Description was changed from ========== Reduce flakyness of timing dependent tests for TestFrameBuffer2.*. BUG= R=stefan@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/6e8224f4ab285f409e431aa83... ========== to ========== Reduce flakyness of timing dependent tests for TestFrameBuffer2.*. BUG= R=stefan@webrtc.org Committed: https://crrev.com/6e8224f4ab285f409e431aa836f9d1027de057d7 Cr-Commit-Position: refs/heads/master@{#12814} ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as 6e8224f4ab285f409e431aa836f9d1027de057d7 (presubmit successful).
Message was sent while issue was closed.
On 2016/05/19 15:08:02, philipel wrote: > Committed patchset #3 (id:40001) manually as > 6e8224f4ab285f409e431aa836f9d1027de057d7 (presubmit successful). The test is still failing on the bots. Can you revert or disable the test? https://build.chromium.org/p/client.webrtc/builders/Win32%20Debug/builds/8019
Message was sent while issue was closed.
Hey, sorry for the flakyness, I have now disabled the flaky test in this CL: https://codereview.webrtc.org/2000573002/ |
