Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 1994013004: Revert of Android: Make base interface for camera1 and camera2 (Closed)

Created:
4 years, 7 months ago by magjed_webrtc
Modified:
4 years, 7 months ago
Reviewers:
perkj_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Android: Make base interface for camera1 and camera2 (patchset #1 id:1 of https://codereview.webrtc.org/1994893002/ ) Reason for revert: Still breaks downstream import. Original issue's description: > Reland of Android: Make base interface for camera1 and camera2 (patchset #1 id:1 of https://codereview.webrtc.org/1979583002/ ) > > Reason for revert: > Downstream code has been updated. > > Original issue's description: > > Revert of Android: Make base interface for camera1 and camera2 (patchset #3 id:80001 of https://codereview.webrtc.org/1895483002/ ) > > > > Reason for revert: > > Breaks downstream import. > > > > Original issue's description: > > > Android: Make base interface for camera1 and camera2 > > > > > > This CL adds a new interface CameraVideoCapturer that extends VideoCapturer with a switchCamera() function. It also moves moves CameraEventsHandler, CameraStatistics, and CameraSwitchHandler from VideoCapturerAndroid to this new interface. The purpose is to prepare for a camera2 implementation that will use the same interfaces and helper class. > > > > > > BUG=webrtc:5519 > > > > > > Committed: https://crrev.com/6bdacaddfb18edef1f0cdd778209f6b05a8f9210 > > > Cr-Commit-Position: refs/heads/master@{#12723} > > > > TBR=perkj@webrtc.org > > # Skipping CQ checks because original CL landed less than 1 days ago. > > NOPRESUBMIT=true > > NOTREECHECKS=true > > NOTRY=true > > BUG=webrtc:5519 > > > > Committed: https://crrev.com/181b5ffdf036427d92929667d9d43bbcff560435 > > Cr-Commit-Position: refs/heads/master@{#12727} > > TBR=perkj@webrtc.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=webrtc:5519 > > Committed: https://crrev.com/d269b023bfe1c321798fe9c8dbd631a562914fe1 > Cr-Commit-Position: refs/heads/master@{#12807} TBR=perkj@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:5519 Committed: https://crrev.com/bd76607abb712f98c01709f240f147e4bd49df6d Cr-Commit-Position: refs/heads/master@{#12809}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -137 lines) Patch
D webrtc/api/java/android/org/webrtc/CameraVideoCapturer.java View 1 chunk +0 lines, -128 lines 0 comments Download
M webrtc/api/java/android/org/webrtc/VideoCapturerAndroid.java View 7 chunks +86 lines, -9 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
magjed_webrtc
Created Revert of Android: Make base interface for camera1 and camera2
4 years, 7 months ago (2016-05-19 11:22:50 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1994013004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1994013004/1
4 years, 7 months ago (2016-05-19 11:22:55 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-19 11:23:03 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/bd76607abb712f98c01709f240f147e4bd49df6d Cr-Commit-Position: refs/heads/master@{#12809}
4 years, 7 months ago (2016-05-19 11:23:14 UTC) #5
magjed_webrtc
4 years, 7 months ago (2016-05-20 12:19:46 UTC) #6
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/1999053002/ by magjed@webrtc.org.

The reason for reverting is: Downstream code has been updated..

Powered by Google App Engine
This is Rietveld 408576698