Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 1992813007: Remove AppRTCUtils.NonThreadSafe in AppRTC Android Demo (Closed)

Created:
4 years, 7 months ago by sakal
Modified:
4 years, 7 months ago
Reviewers:
magjed_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove AppRTCUtils.NonThreadSafe in AppRTC Android Demo ThreadUtils.ThreadChecker in WebRTC does the same thing. No point in having a duplicate implementation. Committed: https://crrev.com/2d285ca150e88d1f00e16f05aaf7caa66fe984c1 Cr-Commit-Position: refs/heads/master@{#12824}

Patch Set 1 #

Patch Set 2 : Reorder imports #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -36 lines) Patch
M webrtc/examples/androidapp/src/org/appspot/apprtc/AppRTCProximitySensor.java View 1 8 chunks +9 lines, -18 lines 0 comments Download
M webrtc/examples/androidapp/src/org/appspot/apprtc/util/AppRTCUtils.java View 1 chunk +0 lines, -18 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
sakal
Magnus, please take a look.
4 years, 7 months ago (2016-05-19 12:49:09 UTC) #3
magjed_webrtc
lgtm
4 years, 7 months ago (2016-05-20 07:46:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1992813007/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1992813007/20001
4 years, 7 months ago (2016-05-20 07:47:21 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-20 10:16:07 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-20 10:16:12 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2d285ca150e88d1f00e16f05aaf7caa66fe984c1
Cr-Commit-Position: refs/heads/master@{#12824}

Powered by Google App Engine
This is Rietveld 408576698