Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1992253005: Removing PORTALLOCATOR_ENABLE_SHAKER. (Closed)

Created:
4 years, 7 months ago by Taylor Brandstetter
Modified:
4 years, 7 months ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Removing PORTALLOCATOR_ENABLE_SHAKER. It's not used by anything, and is obsoleted by connection pruning, candidate pruning, timeouts, etc. R=pthatcher@webrtc.org Committed: https://crrev.com/54f1d9bafd6691f2f207c879e013f16f4d296f30 Cr-Commit-Position: refs/heads/master@{#12834}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -51 lines) Patch
M webrtc/p2p/base/portallocator.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/p2p/client/basicportallocator.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/p2p/client/basicportallocator.cc View 5 chunks +0 lines, -49 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Taylor Brandstetter
Code deletion, yay
4 years, 7 months ago (2016-05-19 23:11:55 UTC) #2
pthatcher1
lgtm
4 years, 7 months ago (2016-05-20 01:04:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1992253005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1992253005/1
4 years, 7 months ago (2016-05-20 20:43:20 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_rel on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_rel/builds/15317)
4 years, 7 months ago (2016-05-20 21:05:30 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1992253005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1992253005/1
4 years, 7 months ago (2016-05-20 22:14:08 UTC) #9
Taylor Brandstetter
4 years, 7 months ago (2016-05-20 22:38:05 UTC) #11
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
54f1d9bafd6691f2f207c879e013f16f4d296f30 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698