Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(610)

Unified Diff: webrtc/voice_engine/channel.h

Issue 1991233004: Moved creation of AudioDecoderFactory to inside PeerConnectionFactory. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@audio-decoder-factory-injections-3
Patch Set: Removed explicit constructor qualifier. Fixed comment grammar. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/voice_engine/channel.h
diff --git a/webrtc/voice_engine/channel.h b/webrtc/voice_engine/channel.h
index 58b78ced3d3cc81be405ec601597a1bcba3e4ebc..c1a5c1c7b6cfba21f082ed0bf2fdc597faa8ff43 100644
--- a/webrtc/voice_engine/channel.h
+++ b/webrtc/voice_engine/channel.h
@@ -199,6 +199,12 @@ class Channel
void SetSink(std::unique_ptr<AudioSinkInterface> sink);
+ // TODO(ossu): Don't use! It's only here to confirm that the decoder factory
+ // passed into AudioReceiveStream is the same as the one set when creating the
+ // ADM. Once Channel creation is moved into Audio{Send,Receive}Stream this can
+ // go.
+ const rtc::scoped_refptr<AudioDecoderFactory>& GetAudioDecoderFactory() const;
+
// API methods
// VoEBase
@@ -582,6 +588,9 @@ class Channel
std::unique_ptr<TransportFeedbackProxy> feedback_observer_proxy_;
std::unique_ptr<TransportSequenceNumberProxy> seq_num_allocator_proxy_;
std::unique_ptr<RtpPacketSenderProxy> rtp_packet_sender_proxy_;
+
+ // TODO(ossu): Remove once GetAudioDecoderFactory() is no longer needed.
+ rtc::scoped_refptr<AudioDecoderFactory> decoder_factory_;
};
} // namespace voe

Powered by Google App Engine
This is Rietveld 408576698