Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Unified Diff: webrtc/audio/audio_receive_stream.cc

Issue 1991233004: Moved creation of AudioDecoderFactory to inside PeerConnectionFactory. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@audio-decoder-factory-injections-3
Patch Set: Removed explicit constructor qualifier. Fixed comment grammar. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/audio/audio_receive_stream.cc
diff --git a/webrtc/audio/audio_receive_stream.cc b/webrtc/audio/audio_receive_stream.cc
index fb17fccefce638c9ad58f894c2c39b88254acef9..2a7fc62c77f847c8967ca36994c0bea46acf9767 100644
--- a/webrtc/audio/audio_receive_stream.cc
+++ b/webrtc/audio/audio_receive_stream.cc
@@ -94,6 +94,14 @@ AudioReceiveStream::AudioReceiveStream(
channel_proxy_ = voe_impl->GetChannelProxy(config_.voe_channel_id);
channel_proxy_->SetLocalSSRC(config.rtp.local_ssrc);
+ // This is where we'd like to set the decoder factory to use. However, since
the sun 2016/05/30 19:09:53 A TODO(ossu) seems appropriate here I think.
ossu 2016/06/02 15:47:47 Acknowledged.
+ // it needs to be included when constructing Channel, we cannot do that until
+ // we're able to move Channel ownership into the Audio{Send,Receive}Streams.
+ // The best we can do is check that we're not trying to use two different
+ // factories using the different interfaces.
+ RTC_CHECK(config.decoder_factory);
+ RTC_CHECK(config.decoder_factory == channel_proxy_->GetAudioDecoderFactory());
the sun 2016/05/30 19:09:53 RTC_CHECK_EQ
ossu 2016/06/02 15:47:47 Acknowledged.
+
channel_proxy_->RegisterExternalTransport(config.rtcp_send_transport);
for (const auto& extension : config.rtp.extensions) {

Powered by Google App Engine
This is Rietveld 408576698