webrtc/modules/audio_coding/acm2/audio_coding_module_impl.h - Issue 1991233004: Moved creation of AudioDecoderFactory to inside PeerConnectionFactory.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_coding/acm2/audio_coding_module_impl.h

Issue 1991233004: Moved creation of AudioDecoderFactory to inside PeerConnectionFactory. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@audio-decoder-factory-injections-3

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webrtc/modules/audio_coding/acm2/audio_coding_module_impl.h

diff --git a/webrtc/modules/audio_coding/acm2/audio_coding_module_impl.h b/webrtc/modules/audio_coding/acm2/audio_coding_module_impl.h

index fa0ac90ec468a64cc4834e3ca687493cc0185be2..c098e62b9914da91662e7690a5b73c8e61f8a316 100644

--- a/webrtc/modules/audio_coding/acm2/audio_coding_module_impl.h

+++ b/webrtc/modules/audio_coding/acm2/audio_coding_module_impl.h

@@ -275,8 +275,6 @@ class AudioCodingModuleImpl final : public AudioCodingModule {

std::unique_ptr<AudioDecoder> isac_decoder_16k_ GUARDED_BY(acm_crit_sect_);

std::unique_ptr<AudioDecoder> isac_decoder_32k_ GUARDED_BY(acm_crit_sect_);

- rtc::scoped_refptr<AudioDecoderFactory> decoder_factory_;

ossu 2016/05/19 16:08:48 This is already removed by patch set 3 of https://

kwiberg-webrtc 2016/05/30 10:04:27 Acknowledged.

// This is to keep track of CN instances where we can send DTMFs.

uint8_t previous_pltype_ GUARDED_BY(acm_crit_sect_);

« webrtc/media/engine/webrtcvoiceengine_unittest.cc ('K') | « webrtc/media/engine/webrtcvoiceengine_unittest.cc ('k') | webrtc/voice_engine/channel.h » ('j') | no next file with comments »