Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: webrtc/voice_engine/channel.h

Issue 1991233004: Moved creation of AudioDecoderFactory to inside PeerConnectionFactory. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@audio-decoder-factory-injections-3
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 181 matching lines...) Expand 10 before | Expand all | Expand 10 after
192 OutputMixer& outputMixer, 192 OutputMixer& outputMixer,
193 TransmitMixer& transmitMixer, 193 TransmitMixer& transmitMixer,
194 ProcessThread& moduleProcessThread, 194 ProcessThread& moduleProcessThread,
195 AudioDeviceModule& audioDeviceModule, 195 AudioDeviceModule& audioDeviceModule,
196 VoiceEngineObserver* voiceEngineObserver, 196 VoiceEngineObserver* voiceEngineObserver,
197 rtc::CriticalSection* callbackCritSect); 197 rtc::CriticalSection* callbackCritSect);
198 int32_t UpdateLocalTimeStamp(); 198 int32_t UpdateLocalTimeStamp();
199 199
200 void SetSink(std::unique_ptr<AudioSinkInterface> sink); 200 void SetSink(std::unique_ptr<AudioSinkInterface> sink);
201 201
202 // TODO(ossu): Don't use! It's only here to confirm that the decoder factory
203 // passed into AudioReceiveStream is the same as the one set when creating the
204 // ADM. Once Channel creation is moved into Audio{Send,Receive}Stream this can
205 // go.
206 const rtc::scoped_refptr<AudioDecoderFactory>& GetAudioDecoderFactory() const;
207
202 // API methods 208 // API methods
203 209
204 // VoEBase 210 // VoEBase
205 int32_t StartPlayout(); 211 int32_t StartPlayout();
206 int32_t StopPlayout(); 212 int32_t StopPlayout();
207 int32_t StartSend(); 213 int32_t StartSend();
208 int32_t StopSend(); 214 int32_t StopSend();
209 int32_t StartReceiving(); 215 int32_t StartReceiving();
210 int32_t StopReceiving(); 216 int32_t StopReceiving();
211 217
(...skipping 363 matching lines...) Expand 10 before | Expand all | Expand 10 after
575 std::unique_ptr<NetworkPredictor> network_predictor_; 581 std::unique_ptr<NetworkPredictor> network_predictor_;
576 // An associated send channel. 582 // An associated send channel.
577 rtc::CriticalSection assoc_send_channel_lock_; 583 rtc::CriticalSection assoc_send_channel_lock_;
578 ChannelOwner associate_send_channel_ GUARDED_BY(assoc_send_channel_lock_); 584 ChannelOwner associate_send_channel_ GUARDED_BY(assoc_send_channel_lock_);
579 585
580 bool pacing_enabled_; 586 bool pacing_enabled_;
581 PacketRouter* packet_router_ = nullptr; 587 PacketRouter* packet_router_ = nullptr;
582 std::unique_ptr<TransportFeedbackProxy> feedback_observer_proxy_; 588 std::unique_ptr<TransportFeedbackProxy> feedback_observer_proxy_;
583 std::unique_ptr<TransportSequenceNumberProxy> seq_num_allocator_proxy_; 589 std::unique_ptr<TransportSequenceNumberProxy> seq_num_allocator_proxy_;
584 std::unique_ptr<RtpPacketSenderProxy> rtp_packet_sender_proxy_; 590 std::unique_ptr<RtpPacketSenderProxy> rtp_packet_sender_proxy_;
591
592 // TODO(ossu): Remove once GetAudioDecoderFactory() is no longer needed.
593 rtc::scoped_refptr<AudioDecoderFactory> decoder_factory_;
585 }; 594 };
586 595
587 } // namespace voe 596 } // namespace voe
588 } // namespace webrtc 597 } // namespace webrtc
589 598
590 #endif // WEBRTC_VOICE_ENGINE_CHANNEL_H_ 599 #endif // WEBRTC_VOICE_ENGINE_CHANNEL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698