Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 1990593002: Add missing headers and fix some missing dependencies (Closed)

Created:
4 years, 7 months ago by kjellander_webrtc
Modified:
4 years, 7 months ago
CC:
webrtc-reviews_webrtc.org, hlundin-webrtc, yujie_mao (webrtc), kwiberg-webrtc, Andrew MacDonald, stefan-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, qiang.lu, niklas.enbom, aluebs-webrtc, peah-webrtc, minyue-webrtc, the sun, pbos-webrtc, mflodman, bjornv1
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add missing headers and fix some missing dependencies This is the first CL in a series of major cleanup and dependency corrections needed in order to satisfy 'gn check'. BUG=webrtc:4243, webrtc:5589 NOTRY=True Committed: https://crrev.com/7bb6e75723eb64af079446cc6e3ff08c74fe02e4 Cr-Commit-Position: refs/heads/master@{#12790}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -3 lines) Patch
M webrtc/BUILD.gn View 4 chunks +9 lines, -1 line 0 comments Download
M webrtc/common.gyp View 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/webrtc.gyp View 3 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 16 (9 generated)
kjellander_webrtc
pbos: review henrika: root owner rubberstamp
4 years, 7 months ago (2016-05-18 08:18:11 UTC) #7
henrika_webrtc
LGTM
4 years, 7 months ago (2016-05-18 08:26:11 UTC) #8
pbos-webrtc
lgtm
4 years, 7 months ago (2016-05-18 10:47:23 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1990593002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1990593002/20001
4 years, 7 months ago (2016-05-18 11:04:41 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 7 months ago (2016-05-18 11:06:18 UTC) #13
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/7bb6e75723eb64af079446cc6e3ff08c74fe02e4 Cr-Commit-Position: refs/heads/master@{#12790}
4 years, 7 months ago (2016-05-18 11:06:29 UTC) #15
kjellander_webrtc
4 years, 7 months ago (2016-05-18 12:00:42 UTC) #16
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:20001) has been created in
https://codereview.webrtc.org/1989823002/ by kjellander@webrtc.org.

The reason for reverting is: This breaks our Chromium WebRTC FYI bots:
https://build.chromium.org/p/chromium.webrtc.fyi/builders/Linux%20Builder/bui...

/mnt/data/b/build/slave/Linux_Builder/build/src/buildtools/linux64/gn gen
//out/Release --check
  -> returned 1
ERROR at //content/renderer/media/rtc_video_decoder.cc:24:11: Can't include this
header from here.
#include "third_party/webrtc/video_frame.h"
          ^-------------------------------
The target:
  //content/renderer:renderer
is including a file from the target:
  //third_party/webrtc:webrtc_common


The //content/renderer:renderer target should probably be updated to depend on  
//third_party/webrtc:webrtc_common before relanding this..

Powered by Google App Engine
This is Rietveld 408576698