Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 1990373002: Fix building of bwe_test_logging.cc in gyp and gn builds (Closed)

Created:
4 years, 7 months ago by brucedawson
Modified:
4 years, 7 months ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix building of bwe_test_logging.cc in gyp and gn builds bwe_test_logging.cc is supposed to be conditionally built in gyp builds but, due to a path error in the sources! expressions it was always compiled. Meanwhile, compilation of bwe_test_logging.cc was never set up for gn builds. This fixes both of these problems. BUG=604060 Committed: https://crrev.com/07df20b51ab50078263f43a9a516b7ac7130d42e Cr-Commit-Position: refs/heads/master@{#12842}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -2 lines) Patch
M webrtc/modules/remote_bitrate_estimator/BUILD.gn View 2 chunks +9 lines, -0 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator.gypi View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
brucedawson
PTAL. I think this corrects the .gyp and .gn files to match the intent but ...
4 years, 7 months ago (2016-05-19 19:03:17 UTC) #2
stefan-webrtc
Looks correct. lgtm
4 years, 7 months ago (2016-05-22 23:14:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1990373002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1990373002/1
4 years, 7 months ago (2016-05-22 23:14:25 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-23 00:15:07 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-23 00:15:16 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/07df20b51ab50078263f43a9a516b7ac7130d42e
Cr-Commit-Position: refs/heads/master@{#12842}

Powered by Google App Engine
This is Rietveld 408576698