Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(548)

Issue 1990063005: Delete obsolete cricket::VideoFrame method names. (Closed)

Created:
4 years, 7 months ago by nisse-webrtc
Modified:
4 years, 7 months ago
Reviewers:
perkj_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Delete obsolete cricket::VideoFrame methods. GetWidth and GetHeight (renamed to width and height), GetNativeHandle (replaced by video_frame_buffer()->native_handle). TBR=tkchin@webrtc.org (trivial changes to objc RTCVideoFrame and VideoRendererAdapter) BUG=webrtc:5682 Committed: https://crrev.com/04ebea362911cc34a7000b7cffd311b7c24a69d3 Cr-Commit-Position: refs/heads/master@{#12822}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -27 lines) Patch
M webrtc/api/java/jni/peerconnection_jni.cc View 2 chunks +6 lines, -5 lines 0 comments Download
M webrtc/media/base/videoframe.h View 1 chunk +0 lines, -11 lines 0 comments Download
M webrtc/media/engine/webrtcvideoframe.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/media/engine/webrtcvideoframe.cc View 2 chunks +1 line, -5 lines 0 comments Download
M webrtc/media/engine/webrtcvideoframe_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M webrtc/sdk/objc/Framework/Classes/RTCVideoFrame.mm View 1 chunk +3 lines, -2 lines 0 comments Download
M webrtc/sdk/objc/Framework/Classes/RTCVideoRendererAdapter.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1990063005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1990063005/1
4 years, 7 months ago (2016-05-19 12:53:16 UTC) #2
nisse-webrtc
This cl deletes old method names. It is likely to break some downstream applications, needs ...
4 years, 7 months ago (2016-05-19 12:56:54 UTC) #5
perkj_webrtc
lgtm
4 years, 7 months ago (2016-05-19 14:45:21 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
4 years, 7 months ago (2016-05-19 14:54:02 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1990063005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1990063005/1
4 years, 7 months ago (2016-05-20 08:15:03 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-20 08:48:50 UTC) #13
commit-bot: I haz the power
4 years, 7 months ago (2016-05-20 08:49:02 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/04ebea362911cc34a7000b7cffd311b7c24a69d3
Cr-Commit-Position: refs/heads/master@{#12822}

Powered by Google App Engine
This is Rietveld 408576698