Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 1989823002: Revert of Add missing headers and fix some missing dependencies (Closed)

Created:
4 years, 7 months ago by kjellander_webrtc
Modified:
4 years, 7 months ago
CC:
webrtc-reviews_webrtc.org, hlundin-webrtc, yujie_mao (webrtc), kwiberg-webrtc, Andrew MacDonald, stefan-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, qiang.lu, niklas.enbom, aluebs-webrtc, peah-webrtc, minyue-webrtc, the sun, pbos-webrtc, mflodman, bjornv1
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Add missing headers and fix some missing dependencies (patchset #1 id:20001 of https://codereview.webrtc.org/1990593002/ ) Reason for revert: This breaks our Chromium WebRTC FYI bots: https://build.chromium.org/p/chromium.webrtc.fyi/builders/Linux%20Builder/builds/6173 /mnt/data/b/build/slave/Linux_Builder/build/src/buildtools/linux64/gn gen //out/Release --check -> returned 1 ERROR at //content/renderer/media/rtc_video_decoder.cc:24:11: Can't include this header from here. #include "third_party/webrtc/video_frame.h" ^------------------------------- The target: //content/renderer:renderer is including a file from the target: //third_party/webrtc:webrtc_common The //content/renderer:renderer target should probably be updated to depend on //third_party/webrtc:webrtc_common before relanding this. Original issue's description: > Add missing headers and fix some missing dependencies > > This is the first CL in a series of major cleanup and dependency > corrections needed in order to satisfy 'gn check'. > > BUG=webrtc:4243, webrtc:5589 > NOTRY=True > > Committed: https://crrev.com/7bb6e75723eb64af079446cc6e3ff08c74fe02e4 > Cr-Commit-Position: refs/heads/master@{#12790} TBR=pbos@webrtc.org,henrika@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:4243, webrtc:5589 Committed: https://crrev.com/84f8df71afd1d9705fcbae5cf828816876f66156 Cr-Commit-Position: refs/heads/master@{#12793}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -16 lines) Patch
M webrtc/BUILD.gn View 4 chunks +1 line, -9 lines 0 comments Download
M webrtc/common.gyp View 1 chunk +1 line, -2 lines 0 comments Download
M webrtc/webrtc.gyp View 3 chunks +1 line, -5 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
kjellander_webrtc
Created Revert of Add missing headers and fix some missing dependencies
4 years, 7 months ago (2016-05-18 12:00:42 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1989823002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1989823002/1
4 years, 7 months ago (2016-05-18 12:00:45 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-18 12:00:55 UTC) #4
commit-bot: I haz the power
4 years, 7 months ago (2016-05-18 12:01:01 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/84f8df71afd1d9705fcbae5cf828816876f66156
Cr-Commit-Position: refs/heads/master@{#12793}

Powered by Google App Engine
This is Rietveld 408576698