Fix UBSan errors (left shift of negative value)

webrtc/modules/audio_coding/codecs/isac/fix/source/entropy_coding.c

 /*
  *  Copyright (c) 2011 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 237 matching lines @@
 
   for (n = 0; n < FRAMESAMPLES/8; n++)
     diffQ16[n] = (CS_ptrQ9[n] * (CorrQ11[1] >> shftVal) + 2) >> 2;
   for (k = 2; k < AR_ORDER; k += 2) {
     CS_ptrQ9 = WebRtcIsacfix_kCos[k];
     for (n = 0; n < FRAMESAMPLES/8; n++)
       diffQ16[n] += (CS_ptrQ9[n] * (CorrQ11[k + 1] >> shftVal) + 2) >> 2;
   }
 
   for (k=0; k<FRAMESAMPLES/8; k++) {
-    int32_t diff_q16 = diffQ16[k] << shftVal;
+    int32_t diff_q16 = diffQ16[k] * (1 << shftVal);
     CurveQ16[FRAMESAMPLES / 4 - 1 - k] = CurveQ16[k] - diff_q16;
     CurveQ16[k] += diff_q16;
   }
 }
 
 static void CalcRootInvArSpec(const int16_t *ARCoefQ12,
                               const int32_t gainQ10,
                               uint16_t *CurveQ8)
 {
   int32_t CorrQ11[AR_ORDER+1];
@@ skipping 588 matching lines @@
     matrix1_index_factor2 = &k;
   }
 
   for (j = 0; j < SUBFRAMES; j++) {
     matrix_prod_index = mid_loop_count * j;
     for (k = 0; k < mid_loop_count; k++) {
       int32_t sum32 = 0;
       matrix0_index = matrix0_index_factor1 * (*matrix0_index_factor2);
       matrix1_index = matrix1_index_factor1 * (*matrix1_index_factor2);
       for (n = 0; n < inner_loop_count; n++) {
-        sum32 += (WEBRTC_SPL_MUL_16_32_RSFT16(matrix0[matrix0_index],
-                                              matrix1[matrix1_index] << shift));
+        sum32 += WEBRTC_SPL_MUL_16_32_RSFT16(
+            matrix0[matrix0_index], matrix1[matrix1_index] * (1 << shift));
         matrix0_index += matrix0_index_step;
         matrix1_index += matrix1_index_step;
       }
       matrix_product[matrix_prod_index] = sum32;
       matrix_prod_index++;
     }
   }
 }
 
 /*
@@ skipping 156 matching lines @@
     /* lo band LAR coeffs */
     for (n=0; n<ORDERLO; n++, pos++, poss++) {
       tmp32 = WEBRTC_SPL_MUL_16_32_RSFT16(31208, tmpcoeffs_sQ17[poss]); // (Q16*Q17)>>16 = Q17, with 1/2.1 = 0.47619047619 ~= 31208 in Q16
       tmp32 = tmp32 + WebRtcIsacfix_kMeansShapeQ17[model][poss]; // Q17+Q17 = Q17
       LPCCoefQ17[pos] = tmp32;
     }
 
     /* hi band LAR coeffs */
     for (n=0; n<ORDERHI; n++, pos++, poss++) {
       // ((Q13*Q17)>>16)<<3 = Q17, with 1/0.45 = 2.222222222222 ~= 18204 in Q13
-      tmp32 = WEBRTC_SPL_MUL_16_32_RSFT16(18204, tmpcoeffs_sQ17[poss]) << 3;
+      tmp32 =
+          WEBRTC_SPL_MUL_16_32_RSFT16(18204, tmpcoeffs_sQ17[poss]) * (1 << 3);
       tmp32 = tmp32 + WebRtcIsacfix_kMeansShapeQ17[model][poss]; // Q17+Q17 = Q17
       LPCCoefQ17[pos] = tmp32;
     }
   }
 
 
   *outmodel=model;
 
   return 0;
 }
@@ skipping 969 matching lines @@
 
     index_gQQ[k] = pos2QQ + WebRtcIsacfix_kQuantMinGain[k]; //ATTN: ok?
     if (index_gQQ[k] < 0) {
       index_gQQ[k] = 0;
     }
     else if (index_gQQ[k] > WebRtcIsacfix_kMaxIndGain[k]) {
       index_gQQ[k] = WebRtcIsacfix_kMaxIndGain[k];
     }
   }
 }