Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1666)

Issue 1989223002: Revert of Remove Android x86 compilation trybot from CQ. (Closed)

Created:
4 years, 7 months ago by kjellander_webrtc
Modified:
4 years, 7 months ago
Reviewers:
pbos-webrtc
CC:
webrtc-reviews_webrtc.org
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Remove Android x86 compilation trybot from CQ. (patchset #1 id:1 of https://codereview.webrtc.org/1959923002/ ) Reason for revert: https://codereview.chromium.org/1985413002/ rolled in the fix for libjpeg_turbo's GYP file in Chromium. That was rolled into WebRTC in https://codereview.webrtc.org/1985423004/. That means our Android x86 builds can start working again. Original issue's description: > Remove Android x86 compilation trybot from CQ. > > There's a Goma bug making it fail to compile after rolling in > https://codereview.webrtc.org/1963493002/ > > BUG=chromium:610145 > TBR=pbos@webrtc.org > NOTRY=True > > Committed: https://chromium.googlesource.com/external/webrtc/+/d939d48de2d27d3a79b81adcd71f221673bda40f TBR=pbos@webrtc.org NOTRY=True BUG=chromium:610145 TESTED=Passing build with: GYP_DEFINES='OS=android component=static_library target_arch=ia32' webrtc/build/gyp_webrtc.py ninja -C out/Debug Committed: https://crrev.com/2f5d600918226030fefabe4069bb363425f77d72 Cr-Commit-Position: refs/heads/master@{#12792}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M infra/config/cq.cfg View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
kjellander_webrtc
Created Revert of Remove Android x86 compilation trybot from CQ.
4 years, 7 months ago (2016-05-18 11:36:20 UTC) #1
kjellander_webrtc
4 years, 7 months ago (2016-05-18 11:50:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1989223002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1989223002/1
4 years, 7 months ago (2016-05-18 11:50:24 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-18 11:57:49 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-18 11:57:58 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2f5d600918226030fefabe4069bb363425f77d72
Cr-Commit-Position: refs/heads/master@{#12792}

Powered by Google App Engine
This is Rietveld 408576698