Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issue 1989173002: GN: Disable checks in WebRTC tree due to too many errors. (Closed)

Created:
4 years, 7 months ago by kjellander_webrtc
Modified:
4 years, 7 months ago
Reviewers:
phoglund
CC:
webrtc-reviews_webrtc.org, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

GN: Disable checks in WebRTC tree due to too many errors. We will have to work through addressing these problems with multiple steps, cleaning up one directories one by one. See https://chromium.googlesource.com/chromium/src/+/master/tools/gn/docs/reference.md#gn-file-Variables for documentation on this. BUG=webrtc:5589 TBR=phoglund@webrtc.org TESTED=Successfully ran: gn gen out/Default --check Committed: https://crrev.com/e0615b7dd1b2085ce5b1db095e14c7ca7efbae58 Cr-Commit-Position: refs/heads/master@{#12785}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M .gn View 1 chunk +2 lines, -1 line 1 comment Download

Messages

Total messages: 8 (4 generated)
kjellander_webrtc
4 years, 7 months ago (2016-05-18 07:35:41 UTC) #3
kjellander_webrtc
Committed patchset #1 (id:1) manually as e0615b7dd1b2085ce5b1db095e14c7ca7efbae58 (presubmit successful).
4 years, 7 months ago (2016-05-18 07:36:03 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e0615b7dd1b2085ce5b1db095e14c7ca7efbae58 Cr-Commit-Position: refs/heads/master@{#12785}
4 years, 7 months ago (2016-05-18 07:36:03 UTC) #7
phoglund
4 years, 7 months ago (2016-05-18 08:56:45 UTC) #8
Message was sent while issue was closed.
lgtm

https://codereview.webrtc.org/1989173002/diff/1/.gn
File .gn (right):

https://codereview.webrtc.org/1989173002/diff/1/.gn#newcode21
.gn:21: # TODO(kjellander): Keep adding paths to this list as work in
webrtc:5589 is done.
Nit: 80 chars

Powered by Google App Engine
This is Rietveld 408576698