Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 1989013003: Add test for DirectRTCClient in AppRTC Demo for Android (Closed)

Created:
4 years, 7 months ago by sakal
Modified:
4 years, 7 months ago
Reviewers:
magjed_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add test for DirectRTCClient in AppRTC Demo for Android Test is very simple but should test the basic sanity of the class. Test is implemented as a JUnit test using Robolectric. Also removed unused imports from TCPChannelClientTest. Committed: https://crrev.com/f910ecdfc54251c66ac92b450607844387ae6c14 Cr-Commit-Position: refs/heads/master@{#12804}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -13 lines) Patch
M webrtc/examples/androidapp/src/org/appspot/apprtc/CallActivity.java View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/examples/androidapp/src/org/appspot/apprtc/DirectRTCClient.java View 3 chunks +4 lines, -3 lines 0 comments Download
A webrtc/examples/androidjunit/src/org/appspot/apprtc/DirectRTCClientTest.java View 1 chunk +103 lines, -0 lines 0 comments Download
M webrtc/examples/androidjunit/src/org/appspot/apprtc/TCPChannelClientTest.java View 2 chunks +0 lines, -9 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
sakal
Magjed, please take a look.
4 years, 7 months ago (2016-05-18 12:06:09 UTC) #3
magjed_webrtc
lgtm
4 years, 7 months ago (2016-05-18 15:17:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1989013003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1989013003/1
4 years, 7 months ago (2016-05-18 15:19:57 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
4 years, 7 months ago (2016-05-18 17:20:35 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1989013003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1989013003/1
4 years, 7 months ago (2016-05-19 06:55:26 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-19 07:00:46 UTC) #12
commit-bot: I haz the power
4 years, 7 months ago (2016-05-19 07:00:56 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f910ecdfc54251c66ac92b450607844387ae6c14
Cr-Commit-Position: refs/heads/master@{#12804}

Powered by Google App Engine
This is Rietveld 408576698